Skip to content

Commit f08610c

Browse files
committed
Refactor range expansion tests to clarify expected behavior for edge cases
1 parent c97fbe0 commit f08610c

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/unit/sdk/test_range_expansion.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,14 @@ def test_single_value_in_brackets() -> None:
6464

6565

6666
def test_empty_brackets() -> None:
67-
assert range_expansion("Device[]") == ["Device[]"] # or raise, depending on implementation
67+
assert range_expansion("Device[]") == ["Device[]"]
6868

6969

7070
def test_no_brackets() -> None:
7171
assert range_expansion("Device1") == ["Device1"]
7272

7373

7474
def test_malformed_ranges() -> None:
75-
# These should either return the original or raise, depending on implementation
7675
assert range_expansion("Device[1-]") == ["Device[1-]"]
7776
assert range_expansion("Device[-3]") == ["Device[-3]"]
7877
assert range_expansion("Device[a-]") == ["Device[a-]"]
@@ -84,13 +83,11 @@ def test_duplicate_and_overlapping_values() -> None:
8483

8584

8685
def test_whitespace_handling() -> None:
87-
assert range_expansion("Device[ 1 - 3 ]") == [
88-
"Device[ 1 - 3 ]"
89-
] # or ["Device1", "Device2", "Device3"] if whitespace is handled
86+
assert range_expansion("Device[ 1 - 3 ]") == ["Device[ 1 - 3 ]"]
9087

9188

9289
def test_descending_ranges() -> None:
93-
assert range_expansion("Device[3-1]") == ["Device3", "Device2", "Device1"] # or error, depending on implementation
90+
assert range_expansion("Device[3-1]") == ["Device3", "Device2", "Device1"]
9491

9592

9693
def test_multiple_bracketed_ranges_in_a_row() -> None:
@@ -102,7 +99,6 @@ def test_non_alphanumeric_ranges() -> None:
10299

103100

104101
def test_unicode_ranges() -> None:
105-
# Only if supported by implementation
106102
assert range_expansion("Dev[α-γ]") == ["Devα", "Devβ", "Devγ"] # noqa: RUF001
107103

108104

0 commit comments

Comments
 (0)