Skip to content

Correct autofixable ruff violations #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Correct autofixable ruff violations #106

merged 1 commit into from
Oct 24, 2024

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Oct 23, 2024

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/utils.py 62.50% 3 Missing ⚠️
infrahub_sdk/_importer.py 0.00% 1 Missing ⚠️
infrahub_sdk/ctl/check.py 0.00% 1 Missing ⚠️ 
@@           Coverage Diff            @@
##           develop     #106   +/-   ##
========================================
  Coverage    64.27%   64.27%           
========================================
  Files           74       74           
  Lines         6856     6856           
  Branches      1355     1355           
========================================
  Hits          4407     4407           
  Misses        2098     2098           
  Partials       351      351
Flag Coverage Δ
python-3.10 43.26% <64.28%> (ø)
python-3.11 43.26% <64.28%> (ø)
python-3.12 43.26% <64.28%> (ø)
python-3.9 43.20% <64.28%> (ø)
python-filler-3.12 23.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/cli_commands.py 35.96% <100.00%> (ø)
infrahub_sdk/graphql.py 99.00% <100.00%> (ø)
infrahub_sdk/pytest_plugin/items/__init__.py 100.00% <ø> (ø)
infrahub_sdk/query_groups.py 40.39% <100.00%> (ø)
infrahub_sdk/_importer.py 31.57% <0.00%> (ø)
infrahub_sdk/ctl/check.py 27.00% <0.00%> (ø)
infrahub_sdk/ctl/utils.py 60.29% <62.50%> (ø)

@ogenstad ogenstad marked this pull request as ready for review October 23, 2024 20:11
@ogenstad ogenstad requested a review from a team October 23, 2024 20:11
@ogenstad ogenstad merged commit 39fdcf0 into develop Oct 24, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-ruf-ruleset branch October 24, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajtmccarty ajtmccarty ajtmccarty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogenstad @ajtmccarty