infrahubctl repository add: username flag fix #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…und infrahubctl repostory app.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #172 +/- ##
===========================================
+ Coverage 65.46% 66.22% +0.76%
===========================================
Files 76 76
Lines 6992 7031 +39
Branches 1382 1388 +6
===========================================
+ Hits 4577 4656 +79
+ Misses 2039 1991 -48
- Partials 376 384 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gmazoyer
reviewed
Dec 11, 2024
gmazoyer
reviewed
Dec 12, 2024
gmazoyer
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
ifstatement to add the credentials.usernamewas an empty string, which was being added to Infrahub as an empty string rather thannulland was causing auth issues on initial sync. Default changed from empty string toNone.