Fix issue with menu load due to missing direction #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #177 +/- ##
===========================================
- Coverage 66.22% 66.16% -0.06%
===========================================
Files 76 76
Lines 7031 7046 +15
Branches 1388 1392 +4
===========================================
+ Hits 4656 4662 +6
- Misses 1989 1998 +9
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
infrahubctl menu loadthat would fail with the following errorThe issue was related to the relationships
parent&childrenonCoreMenuhaving the sameidentifier, when we are trying to create nested objects we are searching for the matching relationship on the other node and in some cases the search would return the wrong relationship.