Add testing directory based on infrahub_testcontainers #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarros
force-pushed
the
dga-20241223-testing
branch
from
296b5b8 to
e4d190f
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #183 +/- ##
===========================================
- Coverage 66.48% 65.47% -1.02%
===========================================
Files 78 81 +3
Lines 7123 7249 +126
Branches 1393 1407 +14
===========================================
+ Hits 4736 4746 +10
- Misses 2000 2116 +116
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ajtmccarty
approved these changes
Dec 24, 2024
Contributor
ajtmccarty
left a comment
ajtmccarty
left a comment
There was a problem hiding this comment.
are these supposed to run as part of the CI eventually?
|
|
||
| # @property | ||
| # def seen_routing_keys(self) -> list[str]: | ||
| # return list(self.messages_per_routing_key.keys()) |
Contributor
There was a problem hiding this comment.
are you hoping to uncomment this file in a later PR or should it be deleted?
Contributor
Author
There was a problem hiding this comment.
we need to finish the conversion of all the integration tests, probably best to keep it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some tests utilities previously part of
infrahub.testinginto the SDK underinfrahub_sdk.testing.infrahub_sdk.testingis designed to work with the packageinfrahub_testcontainersthat makes it possible to run integration tests for all projects using the Python SDKAs part of this PR, I fixed 2 integration tests as part of
tests/integration/test_node.py, there is still a lot of work to fix all of them.