Skip to content

Fix value from pool for async client #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Fix value from pool for async client #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5764de4
Fix value from pool for async client
gmazoyer Dec 27, 2024
d5fc53c
Add changelog entry
gmazoyer Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/66.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix behaviour of attribute value coming from resource pools for async client
2 changes: 1 addition & 1 deletion infrahub_sdk/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@
continue

# Process allocated resource from a pool and update attribute
attr.value = object_response[attr_name]
attr.value = object_response[attr_name]["value"]

Check warning on line 1344 in infrahub_sdk/node.py

View check run for this annotation

Codecov / codecov/patch

infrahub_sdk/node.py#L1344 

Added line #L1344 was not covered by tests

for rel_name in self._relationships:
rel = getattr(self, rel_name)
Expand Down
Loading