Merge back stable into develop with resolved conflicts #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client is assigned now via the cached_property.
We don't want a value passed into the function that isn't used, and likewise don't want to change the API for that init function.
The collect_data method has been updated to support acquiring data from both a stored graphql query endpoint and the standard graphql endpoint. Before, only the stored api endpoint was supported.
- Makes a synchronous function - Make .client property of InfrahubTransform a setter/getter - Add client as argument for initialization of InfrahubTransform
Fix infrahub/#8
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #88 +/- ##
===========================================
- Coverage 64.32% 64.26% -0.06%
===========================================
Files 74 74
Lines 6847 6858 +11
Branches 1354 1356 +2
===========================================
+ Hits 4404 4407 +3
- Misses 2091 2099 +8
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ogenstad
changed the title
dgarros
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge back #7 into
developand resolve merge conflicts, also removes the "await" keyword from some new calls to initialize_client() (that used to be an async function)