Fix flakiness on global-activities E2E + cleanup (#7523)

Author: bilalabbad

frontend/app/tests/e2e/activities/global-activities.spec.ts

@@ -4,66 +4,59 @@ import { ACCOUNT_STATE_PATH } from "../../constants";
 import { saveScreenshotForDocs } from "../../utils";
 
 test.describe("Global Activities - List view and filter usage", () => {
-  test.describe.configure({ mode: "parallel" });
   test.use({ storageState: ACCOUNT_STATE_PATH.ADMIN });
-  test.slow();
 
-  test.beforeEach(async function ({ page }) {
-    page.on("response", async (response) => {
-      if (response.status() === 500) {
-        await expect(response.url()).toBe("This URL responded with a 500 status");
-      }
-    });
-  });
-
-  test("1. Reach global activity-log", async ({ page }) => {
+  test("should navigate to global activity log from sidebar", async ({ page }) => {
     await page.goto("/");
 
     await page.getByTestId("sidebar").getByRole("button", { name: "Activity" }).click();
     await page.getByRole("menuitem", { name: "Activities" }).click();
-    // Verify that clicking "Activities" navigates to the activities page
-    const activitiesHeading = page.getByRole("heading", { name: "Activities" });
-    await expect(activitiesHeading).toBeVisible();
+    await expect(page.getByRole("heading", { name: "Activities" })).toBeVisible();
   });
 
-  test("2. View the Activity log page", async ({ page }) => {
-    await test.step("Go to activity log page", async () => {
+  test("should filter activities by primary node tag", async ({ page }) => {
+    await test.step("Navigate to activity log page", async () => {
       await page.goto("/activities");
     });
 
-    await test.step("Choose filters", async () => {
+    await test.step("Apply primary node filter for blue tag", async () => {
       await page.getByRole("button", { name: "Primary Node" }).click();
       await page.getByPlaceholder("Filter...").fill("tag");
       await page.getByRole("option", { name: "Tag", exact: true }).click();
       await page.getByRole("option", { name: "blue" }).click();
       await page.getByRole("button", { name: "Apply" }).click();
 
-      await expect(
-        page.getByLabel("Primary Node contains [object").getByRole("button")
-      ).toContainText("blue");
+      await expect(page.getByRole("button", { name: "Primary Node blue" })).toBeVisible();
       await saveScreenshotForDocs(page, "topics/activity-logs/activity_log_global_filters_primary");
     });
   });
-  test("3. View the Activity log page with children", async ({ page }) => {
-    await test.step("Go to activity log page", async () => {
+
+  test("should filter activities by has children and view event details with children", async ({
+    page,
+  }) => {
+    await test.step("Navigate to activity log page", async () => {
       await page.goto("/activities");
-      const activitiesHeading = page.getByRole("heading", { name: "Activities" });
-      await expect(activitiesHeading).toBeVisible();
+      await expect(page.getByRole("heading", { name: "Activities" })).toBeVisible();
     });
-    await test.step("Choose filters", async () => {
+
+    await test.step("Apply has children filter set to true", async () => {
       await page.getByRole("button", { name: "Has Children" }).click();
       await page.getByText("True").click();
       await page.getByRole("button", { name: "Apply" }).click();
+      await expect(page.getByRole("button", { name: "Has Children true" })).toBeVisible();
       await saveScreenshotForDocs(
         page,
         "topics/activity-logs/activity_log_global_filters_children"
       );
     });
 
-    await test.step("View Event details with children", async () => {
-      const viewMoreLink = page.getByRole("link", { name: /View details/i }).first();
-      await viewMoreLink.click();
+    await test.step("Open event details and verify children are displayed", async () => {
+      await page.getByRole("link", { name: "View details" }).first().click();
 
+      while (await page.getByText("No activity found for this object.").isVisible()) {
+        await page.reload();
+        await expect(page.getByTestId("activities-container").getByText("Loading...")).toBeHidden();
+      }
       // Check that at least one "View more." button is present in the details page
       await expect(page.getByRole("button", { name: "View more" }).first()).toBeVisible();
       await saveScreenshotForDocs(