Require attribute NumberPool to be mandatory and read-only

Author: ogenstad

backend/infrahub/core/schema/schema_branch.py

@@ -1024,6 +1024,14 @@ def validate_attribute_parameters(self) -> None:
     def _validate_number_pool_parameters(
         self, node_schema: NodeSchema, attribute: AttributeSchema, number_pool_parameters: NumberPoolParameters
     ) -> None:
+        if attribute.optional:
+            raise ValidationError(f"{node_schema.kind}.{attribute.name} is a NumberPool it can't be optional")
+
+        if not attribute.read_only:
+            raise ValidationError(
+                f"{node_schema.kind}.{attribute.name} is a NumberPool it has to be a read_only attribute"
+            )
+
         if attribute.inherited:
             generics_with_attribute = []
             for generic_name in node_schema.inherit_from:

backend/tests/unit/core/schema/test_attribute_parameters.py

@@ -58,6 +58,60 @@ def test_number_pool_invalid_range() -> None:
         NodeSchema(**node_schema)
 
 
+def test_number_pool_optional() -> None:
+    node_schema_definition: dict[str, Any] = {
+        "name": "NumberAttribute",
+        "namespace": "Test",
+        "attributes": [
+            {"name": "name", "kind": "Text", "unique": True},
+            {
+                "name": "assigned_number",
+                "kind": "NumberPool",
+                "optional": True,
+                "unique": True,
+                "read_only": True,
+                "parameters": {"start_range": 10, "end_range": 25},
+            },
+        ],
+    }
+    node_schema = NodeSchema(**node_schema_definition)
+
+    schema = SchemaRoot(nodes=[node_schema])
+    schema_branch = SchemaBranch(cache={})
+    schema_branch.load_schema(schema=schema)
+    with pytest.raises(
+        ValidationError, match="TestNumberAttribute.assigned_number is a NumberPool it can't be optional"
+    ):
+        schema_branch.process()
+
+
+def test_number_pool_read_only() -> None:
+    node_schema_definition: dict[str, Any] = {
+        "name": "NumberAttribute",
+        "namespace": "Test",
+        "attributes": [
+            {"name": "name", "kind": "Text", "unique": True},
+            {
+                "name": "assigned_number",
+                "kind": "NumberPool",
+                "optional": False,
+                "unique": True,
+                "read_only": False,
+                "parameters": {"start_range": 10, "end_range": 25},
+            },
+        ],
+    }
+    node_schema = NodeSchema(**node_schema_definition)
+
+    schema = SchemaRoot(nodes=[node_schema])
+    schema_branch = SchemaBranch(cache={})
+    schema_branch.load_schema(schema=schema)
+    with pytest.raises(
+        ValidationError, match="TestNumberAttribute.assigned_number is a NumberPool it has to be a read_only attribute"
+    ):
+        schema_branch.process()
+
+
 def test_number_pool_assign_from_generics() -> None:
     schema = SchemaRoot(generics=[SNOW_TASK], nodes=[SNOW_INCIDENT, SNOW_REQUEST])
     schema_branch = SchemaBranch(cache={})