Fix invalid type for environment variable default

Author: ogenstad

backend/tests/benchmark/test_graphql_query.py

@@ -22,7 +22,7 @@
 from infrahub.graphql.initialization import prepare_graphql_params
 from tests.test_data.dataset04 import load_data
 
-NBR_WARMUP = int(os.getenv("INFRAHUB_BENCHMARK_NBR_WARMUP", 5))
+NBR_WARMUP = int(os.getenv("INFRAHUB_BENCHMARK_NBR_WARMUP", "5"))
 
 
 @pytest.fixture(scope="module")

pyproject.toml

@@ -516,7 +516,6 @@ ignore = [
     "PLR6201",  # Use a `set` literal when testing for membership
     "PLR6301",  # Method could be a function, class method, or static method
     "PLW0603",  # Using the global statement to update `SETTINGS` is discouraged
-    "PLW1508",  # Invalid type for environment variable default; expected `str` or `None`
     "PTH100",   # `os.path.abspath()` should be replaced by `Path.resolve()`
     "PTH102",   # `os.mkdir()` should be replaced by `Path.mkdir()`
     "PTH107",   # `os.remove()` should be replaced by `Path.unlink()`

tasks/shared.py

@@ -28,7 +28,7 @@ class Namespace(str, Enum):
 INFRAHUB_DATABASE = os.getenv("INFRAHUB_DB_TYPE", DatabaseType.NEO4J.value)
 INFRAHUB_ADDRESS = os.getenv("INFRAHUB_ADDRESS", "http://localhost:8000")
 
-INFRAHUB_USE_NATS = bool(os.getenv("INFRAHUB_USE_NATS", False))
+INFRAHUB_USE_NATS = bool(os.getenv("INFRAHUB_USE_NATS", None))
 
 DATABASE_DOCKER_IMAGE = os.getenv("DATABASE_DOCKER_IMAGE", None)
 MEMGRAPH_DOCKER_IMAGE = os.getenv("MEMGRAPH_DOCKER_IMAGE", "memgraph/memgraph-mage:1.19-memgraph-2.19-no-ml")
@@ -47,8 +47,8 @@ class Namespace(str, Enum):
 
 PWD = os.getcwd()
 
-NBR_WORKERS = os.getenv("PYTEST_XDIST_WORKER_COUNT", 1)
-GITHUB_ACTION = os.getenv("GITHUB_ACTION", False)
+NBR_WORKERS = int(os.getenv("PYTEST_XDIST_WORKER_COUNT", "1"))
+GITHUB_ACTION = os.getenv("GITHUB_ACTION"), False
 
 
 SERVICE_SERVER_NAME = "server"