Remove Profile in registry for renamed schema nodes

Fixes #4909

Author: ogenstad

backend/infrahub/core/schema/schema_branch.py

@@ -1642,6 +1642,12 @@ def manage_profile_schemas(self) -> None:
             profile = self.generate_profile_from_node(node=node)
             self.set(name=profile.kind, schema=profile)
             profile_schema_kinds.add(profile.kind)
+
+        for previous_profile in list(self.profiles.keys()):
+            # Ensure that we remove previous profile schemas if a node has been renamed
+            if previous_profile not in profile_schema_kinds:
+                self.delete(name=previous_profile)
+
         if not profile_schema_kinds:
             return
 

backend/tests/integration/schema_lifecycle/test_schema_migration_main.py

@@ -209,6 +209,12 @@ async def test_step03_load(self, db: InfrahubDatabase, client: InfrahubClient, i
         john = persons[0]
         assert not hasattr(john, "height")
 
+        # Ensure that we can query the existing node with graphql endpoint
+        api_persons = await client.filters(kind=PERSON_KIND, firstname__value="John")
+        assert len(api_persons) == 1
+        api_john = api_persons[0]
+        assert not hasattr(api_john, "height")
+
         manufacturers = await registry.manager.query(
             db=db, schema=MANUFACTURER_KIND_03, filters={"name__value": "honda"}
         )

changelog/4909.fixed.md

@@ -0,0 +1 @@
+Remove Profile in registry for renamed schema nodes