Skip to content

Commit 6580250

Browse files
authored
New breadcrumbs for object pages (list, details, etc...) (#7570)
1 parent fc77285 commit 6580250

28 files changed

+827
-85
lines changed

changelog/+breadcrumb.added.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
New breadcrumb navigation:
22

33
- Select and switch branches directly from the breadcrumb
4+
- Display full ancestors lineage of objects (Parents, ancestors for hierarchy schemas, etc...)
5+
- You can now switch object directly from breadcrumb

frontend/app/src/app/router.tsx

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -165,25 +165,9 @@ export const router = createBrowserRouter([
165165
children: [
166166
{
167167
path: ":objectKind",
168-
handle: {
169-
breadcrumb: (match: UIMatch) => {
170-
return {
171-
type: "select",
172-
value: match.params.objectKind,
173-
kind: "schema",
174-
};
175-
},
176-
},
177168
children: [
178169
{
179170
path: ":objectId",
180-
handle: {
181-
breadcrumb: (match: UIMatch) => ({
182-
type: "select",
183-
value: match.params.objectId,
184-
kind: match.params.objectKind,
185-
}),
186-
},
187171
children: [
188172
{
189173
path: "convert",
@@ -210,13 +194,6 @@ export const router = createBrowserRouter([
210194
},
211195
{
212196
path: ":objectid",
213-
handle: {
214-
breadcrumb: (match: UIMatch) => ({
215-
type: "select",
216-
value: match.params.objectid,
217-
kind: match.params.objectKind,
218-
}),
219-
},
220197
children: [
221198
{
222199
index: true,
@@ -439,15 +416,6 @@ export const router = createBrowserRouter([
439416
{
440417
path: ":objectid",
441418
lazy: () => import("@/pages/objects/object-details"),
442-
handle: {
443-
breadcrumb: (match: UIMatch) => {
444-
return {
445-
type: "select",
446-
value: match.params.objectid,
447-
kind: match.params.objectKind,
448-
};
449-
},
450-
},
451419
},
452420
],
453421
},

frontend/app/src/entities/nodes/convert/ui/object-convert.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export function ObjectConvert({ objectSchema, objectId, permission }: ObjectConv
5353
/>
5454

5555
<div className="grid grid-cols-2 gap-2 overflow-auto p-2">
56-
<Card className="col-span-0 p-0">
56+
<Card className="col-span-0 p-0" data-testid="convert-source">
5757
<CardWithBorder.Title>
5858
<h3 className="font-normal">SOURCE</h3>
5959
<h4 className="leading-10">{objectSchema.label}</h4>

0 commit comments

Comments
 (0)