Generate uniqueness_constraints for schema node if hfid exists (#4344)

* Generate uniqueness_constraints for schema node if hfid exists

Fixes #4186

* one more unit test

---------

Co-authored-by: Aaron McCarty <[email protected]>

Author: ogenstad

backend/infrahub/core/schema_manager.py

@@ -778,7 +778,6 @@ def validate_human_friendly_id(self) -> None:
             if not node_schema.human_friendly_id:
                 continue
 
-            has_unique_item = False
             allowed_types = SchemaElementPathType.ATTR | SchemaElementPathType.REL_ONE_ATTR
             for item in node_schema.human_friendly_id:
                 schema_path = self.validate_schema_path(
@@ -788,9 +787,6 @@ def validate_human_friendly_id(self) -> None:
                     element_name="human_friendly_id",
                 )
 
-                if schema_path.attribute_schema.unique:
-                    has_unique_item = True
-
                 if schema_path.is_type_attribute:
                     required_properties = tuple(schema_path.attribute_schema.get_class().get_allowed_property_in_path())
                     if schema_path.attribute_property_name not in required_properties:
@@ -812,11 +808,6 @@ def validate_human_friendly_id(self) -> None:
                             f"{node_schema.kind}. ({item})"
                         )
 
-            if not has_unique_item:
-                raise ValueError(
-                    f"At least one attribute must be unique in the human_friendly_id for {node_schema.kind}."
-                )
-
     def validate_required_relationships(self) -> None:
         reverse_dependency_map: dict[str, set[str]] = {}
         for name in self.node_names + self.generic_names:
@@ -1100,7 +1091,7 @@ def process_human_friendly_id(self) -> None:
                         self.set(name=node.kind, schema=node)
                         break
 
-            if node.human_friendly_id and not node.unique_attributes and not node.uniqueness_constraints:
+            if node.human_friendly_id and not node.uniqueness_constraints:
                 uniqueness_constraints: list[str] = []
                 for item in node.human_friendly_id:
                     schema_attribute_path = node.parse_schema_path(path=item, schema=self)

backend/tests/unit/core/schema_manager/test_manager_schema.py

@@ -192,19 +192,22 @@ async def test_schema_branch_process_inheritance_update_inherited_elements(anima
         ([["breed__value"]], [], ["name__value"]),
         (None, ["breed"], ["name__value"]),
         ([["name__value", "breed__value"]], ["breed"], ["name__value"]),
+        (None, ["name"], ["name__value"]),
+        (None, [], ["name__value", "breed__value"]),
     ],
 )
-async def test_validate_human_friendly_id_uniqueness_failure(
+async def test_validate_human_friendly_id_assign_uniquess_constraints(
     uniqueness_constraints: list[list[str]] | None,
     unique_attributes: list[str],
     human_friendly_id: list[str] | None,
     animal_person_schema_dict,
 ):
     schema = SchemaBranch(cache={}, name="test")
-    for node_schema in animal_person_schema_dict["nodes"]:
+    for node_schema in animal_person_schema_dict["generics"]:
         if node_schema["name"] == "Animal" and node_schema["namespace"] == "Test":
             node_schema["uniqueness_constraints"] = None
             node_schema["human_friendly_id"] = None
+    for node_schema in animal_person_schema_dict["nodes"]:
         if node_schema["name"] == "Dog" and node_schema["namespace"] == "Test":
             node_schema["uniqueness_constraints"] = uniqueness_constraints
             node_schema["human_friendly_id"] = human_friendly_id
@@ -213,9 +216,12 @@ async def test_validate_human_friendly_id_uniqueness_failure(
     schema.load_schema(schema=SchemaRoot(**animal_person_schema_dict))
 
     schema.process_inheritance()
-    schema.sync_uniqueness_constraints_and_unique_attributes()
-    with pytest.raises(ValueError, match=r"At least one attribute must be unique in the human_friendly_id"):
-        schema.validate_human_friendly_id()
+    schema.validate_human_friendly_id()
+    schema.process_human_friendly_id()
+
+    dog_node = schema.get("TestDog")
+    expected_uniqueness_constraints = uniqueness_constraints or [human_friendly_id]
+    assert dog_node.uniqueness_constraints == expected_uniqueness_constraints
 
 
 @pytest.mark.parametrize(

changelog/4186.fixed.md

@@ -0,0 +1 @@
+Ensure schema uniqueness_constraint are created if they are missing and human_friendly_id has been specified for the node