fixed link + added icons in new menu (#4575)

* fix branches link in new menu
* added icons on internal menu items

Author: bilalabbad

backend/infrahub/menu/menu.py

@@ -33,6 +33,7 @@ def _extract_node_icon(model: MainSchemaTypes) -> str:
         namespace="Builtin",
         name="ObjectManagement",
         label="Object Management",
+        icon="mdi:cube-outline",
         protected=True,
         section=MenuSection.INTERNAL,
         order_weight=1000,
@@ -73,6 +74,7 @@ def _extract_node_icon(model: MainSchemaTypes) -> str:
         namespace="Builtin",
         name="ChangeControl",
         label="Change Control",
+        icon="mdi:compare-vertical",
         protected=True,
         section=MenuSection.INTERNAL,
         order_weight=2000,
@@ -81,7 +83,7 @@ def _extract_node_icon(model: MainSchemaTypes) -> str:
                 namespace="Builtin",
                 name="Branches",
                 label="Branches",
-                path="/branche",
+                path="/branches",
                 icon="mdi:layers-triple",
                 protected=True,
                 section=MenuSection.INTERNAL,
@@ -123,6 +125,7 @@ def _extract_node_icon(model: MainSchemaTypes) -> str:
         namespace="Builtin",
         name="UnifiedStorage",
         label="Unified Storage",
+        icon="mdi:archive-arrow-down-outline",
         protected=True,
         section=MenuSection.INTERNAL,
         order_weight=3000,
@@ -163,6 +166,7 @@ def _extract_node_icon(model: MainSchemaTypes) -> str:
         namespace="Builtin",
         name="Admin",
         label="Admin",
+        icon="mdi:settings-outline",
         protected=True,
         section=MenuSection.INTERNAL,
         order_weight=3000,

backend/tests/unit/graphql/mutations/test_menu.py

@@ -43,7 +43,7 @@ async def test_menu_update_protected(db: InfrahubDatabase, register_core_models_
         namespace="Builtin",
         name="Branches",
         label="Branches",
-        path="/branche",
+        path="/branches",
         icon="mdi:layers-triple",
         protected=True,
         section=MenuSection.INTERNAL,
@@ -83,7 +83,7 @@ async def test_menu_delete_protected(db: InfrahubDatabase, register_core_models_
         namespace="Builtin",
         name="Branches",
         label="Branches",
-        path="/branche",
+        path="/branches",
         icon="mdi:layers-triple",
         protected=True,
         section=MenuSection.INTERNAL,