Housekeeping on schema entitities folder (#5807)

- reduce duplication
- moved files and renamed types to better follow our new architecture
- added tests

Author: bilalabbad

frontend/app/src/entities/artifacts/ui/artifact-details.tsx

@@ -7,7 +7,7 @@ import {
 } from "@/entities/nodes/object-items/getSchemaObjectColumns";
 import { getObjectDetailsUrl } from "@/entities/nodes/utils";
 import { getPermission } from "@/entities/permission/utils";
-import { genericsState, schemaState } from "@/entities/schema/stores/schema.atom";
+import { genericSchemasAtom, nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import { schemaKindLabelState } from "@/entities/schema/stores/schemaKindLabel.atom";
 import useQuery from "@/shared/api/graphql/useQuery";
 import { constructPath } from "@/shared/api/rest/fetch";
@@ -28,9 +28,9 @@ import ArtifactHeader from "./artifact-header";
 function ArtifactsDetails() {
   const { objectid } = useParams();
 
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
   const [schemaLabels] = useAtom(schemaKindLabelState);
-  const [genericList] = useAtom(genericsState);
+  const [genericList] = useAtom(genericSchemasAtom);
   const schema = schemaList.find((s) => s.kind === ARTIFACT_OBJECT);
   const generic = genericList.find((s) => s.kind === ARTIFACT_OBJECT);
   useTitle("Artifact details");

frontend/app/src/entities/diff/artifact-diff/artifact-content-diff.tsx

@@ -9,7 +9,7 @@ import { currentBranchAtom } from "@/entities/branches/stores";
 import { createObject } from "@/entities/nodes/api/createObject";
 import { deleteObject } from "@/entities/nodes/api/deleteObject";
 import { getProposedChangesArtifactsThreads } from "@/entities/proposed-changes/api/getProposedChangesArtifactsThreads";
-import { schemaState } from "@/entities/schema/stores/schema.atom";
+import { nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import graphqlClient from "@/shared/api/graphql/graphqlClientApollo";
 import useQuery from "@/shared/api/graphql/useQuery";
 import { fetchStream } from "@/shared/api/rest/fetch";
@@ -98,7 +98,7 @@ export const ArtifactContentDiff = (props: any) => {
   const branch = useAtomValue(currentBranchAtom);
   const date = useAtomValue(datetimeAtom);
   const auth = useAuth();
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
   const [isLoading, setIsLoading] = useState(false);
   const [previousFile, setPreviousFile] = useState("");
   const [newFile, setNewFile] = useState("");

frontend/app/src/entities/diff/artifact-diff/artifact-repo-diff.tsx

@@ -1,5 +1,5 @@
 import { getArtifactDetails } from "@/entities/artifacts/api/getArtifacts";
-import { schemaState } from "@/entities/schema/stores/schema.atom";
+import { nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import useQuery from "@/shared/api/graphql/useQuery";
 import Accordion from "@/shared/components/display/accordion";
 import { Badge } from "@/shared/components/display/badge";
@@ -14,7 +14,7 @@ import { ArtifactContentDiff } from "./artifact-content-diff";
 export const ArtifactRepoDiff = (props: any) => {
   const { diff } = props;
 
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
 
   const schemaData = schemaList.filter((s) => s.kind === "Artifact")[0];
 

frontend/app/src/entities/diff/checks/checks-summary.tsx

@@ -6,7 +6,7 @@ import {
 import { useAuth } from "@/entities/authentication/ui/useAuth";
 import { runCheck } from "@/entities/diff/api/runCheck";
 import { getValidatorsStats } from "@/entities/proposed-changes/ui/checks";
-import { genericsState } from "@/entities/schema/stores/schema.atom";
+import { genericSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import { schemaKindLabelState } from "@/entities/schema/stores/schemaKindLabel.atom";
 import graphqlClient from "@/shared/api/graphql/graphqlClientApollo";
 import { Button } from "@/shared/components/buttons/button-primitive";
@@ -32,7 +32,7 @@ export const ChecksSummary = (props: tChecksSummaryProps) => {
 
   const { proposedChangeId } = useParams();
   const schemaKindLabel = useAtomValue(schemaKindLabelState);
-  const schemaList = useAtomValue(genericsState);
+  const schemaList = useAtomValue(genericSchemasAtom);
   const { isAuthenticated } = useAuth();
 
   const schemaData = schemaList.find((s) => s.kind === PROPOSED_CHANGES_VALIDATOR_OBJECT);

frontend/app/src/entities/diff/file-diff/file-content-diff.tsx

@@ -9,7 +9,7 @@ import { currentBranchAtom } from "@/entities/branches/stores";
 import { createObject } from "@/entities/nodes/api/createObject";
 import { deleteObject } from "@/entities/nodes/api/deleteObject";
 import { getProposedChangesFilesThreads } from "@/entities/proposed-changes/api/getProposedChangesFilesThreads";
-import { schemaState } from "@/entities/schema/stores/schema.atom";
+import { nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import graphqlClient from "@/shared/api/graphql/graphqlClientApollo";
 import useQuery from "@/shared/api/graphql/useQuery";
 import { fetchStream } from "@/shared/api/rest/fetch";
@@ -108,7 +108,7 @@ export const FileContentDiff = (props: any) => {
   const branch = useAtomValue(currentBranchAtom);
   const date = useAtomValue(datetimeAtom);
   const auth = useAuth();
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
   const [isLoading, setIsLoading] = useState(false);
   const [previousFile, setPreviousFile] = useState(false);
   const [newFile, setNewFile] = useState(false);

frontend/app/src/entities/diff/node-diff/comments.tsx

@@ -8,7 +8,7 @@ import { getThreadLabel } from "@/entities/diff/utils";
 import { createObject } from "@/entities/nodes/api/createObject";
 import { deleteObject } from "@/entities/nodes/api/deleteObject";
 import { getProposedChangesObjectThreadComments } from "@/entities/proposed-changes/api/getProposedChangesObjectThreadComments";
-import { schemaState } from "@/entities/schema/stores/schema.atom";
+import { nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import graphqlClient from "@/shared/api/graphql/graphqlClientApollo";
 import useQuery from "@/shared/api/graphql/useQuery";
 import { AddComment } from "@/shared/components/conversations/add-comment";
@@ -32,7 +32,7 @@ export const DiffComments = (props: tDiffComments) => {
   const { path, refetch: parentRefetch } = props;
 
   const { proposedChangeId } = useParams();
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
   const auth = useAuth();
   const branch = useAtomValue(currentBranchAtom);
   const date = useAtomValue(datetimeAtom);

frontend/app/src/entities/diff/node-diff/thread.tsx

@@ -1,7 +1,7 @@
 import { PROPOSED_CHANGES_OBJECT_THREAD_OBJECT } from "@/config/constants";
 import { getThreadLabel, getThreadTitle } from "@/entities/diff/utils";
 import { getProposedChangesObjectThreads } from "@/entities/proposed-changes/api/getProposedChangesObjectThreads";
-import { schemaState } from "@/entities/schema/stores/schema.atom";
+import { nodeSchemasAtom } from "@/entities/schema/stores/schema.atom";
 import useQuery from "@/shared/api/graphql/useQuery";
 import { SidePanelTitle } from "@/shared/components/display/sidepanel-title";
 import SlideOver from "@/shared/components/display/slide-over";
@@ -23,7 +23,7 @@ type tDiffThread = {
 
 export const DiffThread = ({ path }: tDiffThread) => {
   const { proposedChangeId } = useParams();
-  const [schemaList] = useAtom(schemaState);
+  const [schemaList] = useAtom(nodeSchemasAtom);
   const { node, currentBranch } = use(DiffContext);
   const [showThread, setShowThread] = useState(false);
 

frontend/app/src/entities/diff/ui/diff-tree.tsx

@@ -2,7 +2,7 @@ import { DiffNode } from "@/entities/diff/node-diff/types";
 import { DiffBadge } from "@/entities/diff/node-diff/utils";
 import { TREE_ROOT_ID } from "@/entities/ipam/constants";
 import { EMPTY_TREE, addItemsToTree } from "@/entities/ipam/ipam-tree/utils";
-import { useSchema } from "@/entities/schema/hooks/useSchema";
+import { useSchema } from "@/entities/schema/ui/hooks/useSchema";
 import { Tooltip } from "@/shared/components/ui/tooltip";
 import { Tree, TreeItemProps, TreeProps } from "@/shared/components/ui/tree";
 import { Icon } from "@iconify-icon/react";

frontend/app/src/entities/events/ui/global-node-event.tsx

@@ -1,6 +1,6 @@
 import { NodeLabel } from "@/entities/nodes/object/ui/display-label";
-import { useSchema } from "@/entities/schema/hooks/useSchema";
 import { schemaKindLabelState } from "@/entities/schema/stores/schemaKindLabel.atom";
+import { useSchema } from "@/entities/schema/ui/hooks/useSchema";
 import { NodeMutatedEvent } from "@/shared/api/graphql/generated/graphql";
 import { constructPath } from "@/shared/api/rest/fetch";
 import { Link } from "@/shared/components/ui/link";

frontend/app/src/entities/graphql/ui/graphql-query-details-card.tsx

@@ -2,7 +2,7 @@ import { RELATIONSHIP_VIEW_BLACKLIST } from "@/config/constants";
 import { AttributeType, ObjectAttributeValue } from "@/entities/nodes/getObjectItemDisplayValue";
 import { getObjectDetailsUrl, getObjectDetailsUrl2 } from "@/entities/nodes/utils";
 import { Permission } from "@/entities/permission/types";
-import { iNodeSchema } from "@/entities/schema/stores/schema.atom";
+import { NodeSchema } from "@/entities/schema/types";
 import { CoreGraphQlQuery } from "@/shared/api/graphql/generated/graphql";
 import { constructPath } from "@/shared/api/rest/fetch";
 import { CopyToClipboard } from "@/shared/components/buttons/copy-to-clipboard";
@@ -17,7 +17,7 @@ import { Icon } from "@iconify-icon/react";
 
 type GraphqlQueryDetailsCardProps = {
   data: CoreGraphQlQuery;
-  schema: iNodeSchema;
+  schema: NodeSchema;
   refetch: () => Promise<unknown>;
   permission: Permission;
 };