Allow passing filters to object count query in UI (#6514)

Author: bilalabbad

changelog/object-count.added.md

@@ -0,0 +1 @@
+On object list views, The number of objects now changes when you apply filters in list views.

frontend/app/src/entities/nodes/object-header.tsx

@@ -29,7 +29,7 @@ const ObjectItemsHeader = ({ schema }: ObjectHeaderProps) => {
     isPending,
     isRefetching,
     isError,
-  } = useObjectsCount({ schemaKind: schema.kind as string, filters });
+  } = useObjectsCount({ objectKind: schema.kind as string, filters });
 
   const refetchObjects = () => {
     queryClient.invalidateQueries({

frontend/app/src/entities/nodes/object/api/get-objects-count-from-api.ts

@@ -1,13 +1,23 @@
 import graphqlClient from "@/shared/api/graphql/graphqlClientApollo";
+import { addFiltersToRequest } from "@/shared/api/graphql/utils";
 import { ContextParams } from "@/shared/api/types";
+import { Filter } from "@/shared/hooks/useFilters";
 import { gql } from "@apollo/client";
 import { jsonToGraphQLQuery } from "json-to-graphql-query";
 
-const getObjectsCountQuery = (kind: string) => {
+export interface getObjectsCountQueryParams {
+  objectKind: string;
+  filters?: Array<Filter>;
+}
+
+const getObjectsCountQuery = ({ objectKind, filters }: getObjectsCountQueryParams) => {
   const query = {
     query: {
-      __name: `GetObjectsCount${kind}`,
-      [kind]: {
+      __name: `GetObjectsCount${objectKind}`,
+      [objectKind]: {
+        __args: {
+          ...(filters ? addFiltersToRequest(filters) : {}),
+        },
         count: true,
       },
     },
@@ -16,18 +26,24 @@ const getObjectsCountQuery = (kind: string) => {
   return gql(jsonToGraphQLQuery(query));
 };
 
-export type GetObjectsCountFromApiParams = ContextParams & { schemaKind: string };
+export interface GetObjectsCountFromApiParams extends ContextParams {
+  objectKind: string;
+  filters?: Array<Filter>;
+}
 
 export const getObjectsCountFromApi = async ({
-  schemaKind,
+  objectKind,
+  filters,
   branchName,
   atDate,
 }: GetObjectsCountFromApiParams) => {
   return graphqlClient.query({
-    query: getObjectsCountQuery(schemaKind),
+    query: getObjectsCountQuery({ objectKind, filters }),
     context: {
       branch: branchName,
       date: atDate,
+      queryDeduplication: false,
+      processErrorMessage: () => {},
     },
   });
 };

frontend/app/src/entities/nodes/object/domain/get-objects-count.query.ts

@@ -5,16 +5,16 @@ import { useAtomValue } from "jotai";
 import { GetObjectsCountParams, getObjectsCount } from "./get-objects-count";
 
 export function getObjectsCountQueryOptions({
-  schemaKind,
+  objectKind,
   filters,
   branchName,
   atDate,
 }: GetObjectsCountParams) {
   return queryOptions({
-    queryKey: [branchName, atDate, "objects", schemaKind, "count", JSON.stringify(filters)],
+    queryKey: [branchName, atDate, "objects", objectKind, "count", JSON.stringify(filters)],
     queryFn: async () => {
       return getObjectsCount({
-        schemaKind,
+        objectKind,
         branchName,
         atDate,
         filters,

frontend/app/src/entities/nodes/object/domain/get-objects-count.ts

@@ -1,28 +1,31 @@
-import { getObjectsCountFromApi } from "@/entities/nodes/object/api/get-objects-count-from-api";
-import { ContextParams } from "@/shared/api/types";
-import { Filter } from "@/shared/hooks/useFilters";
+import {
+  GetObjectsCountFromApiParams,
+  getObjectsCountFromApi,
+} from "@/entities/nodes/object/api/get-objects-count-from-api";
 
-export type GetObjectsCountParams = ContextParams & {
-  schemaKind: string;
-  filters?: Array<Filter>;
-};
+export type GetObjectsCountParams = GetObjectsCountFromApiParams;
 
 export type GetObjectsCount = (args: GetObjectsCountParams) => Promise<number>;
 
 export const getObjectsCount: GetObjectsCount = async ({
-  schemaKind,
+  objectKind,
   branchName,
   atDate,
   filters = [],
 }) => {
   const kindFilter = filters?.find((filter) => filter.name === "kind__value");
-  const schemaKindToQuery: string = kindFilter?.value ?? schemaKind;
+  const schemaKindToQuery: string = kindFilter?.value ?? objectKind;
 
-  const { data } = await getObjectsCountFromApi({
-    schemaKind: schemaKindToQuery,
+  const { data, errors } = await getObjectsCountFromApi({
+    objectKind: schemaKindToQuery,
     branchName,
     atDate,
+    filters,
   });
 
+  if (errors?.[0]?.message) {
+    throw new Error(errors[0].message);
+  }
+
   return data[schemaKindToQuery].count;
 };