Skip to content

Commit bfc52c7

Browse files
authored
Removed unused dependencies + fixed flaky e2e tests (#4541)
1 parent 1c46573 commit bfc52c7

File tree

5 files changed

+63
-30
lines changed

5 files changed

+63
-30
lines changed

frontend/app/biome.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,14 @@
33
"vcs": { "enabled": false, "clientKind": "git", "useIgnoreFile": false },
44
"files": {
55
"ignoreUnknown": false,
6-
"ignore": ["./coverage", "./dist", "./playwright-report", "./src/generated", "./test-results"]
6+
"ignore": [
7+
"./coverage",
8+
"./dist",
9+
"./playwright-report",
10+
"./src/generated",
11+
"./test-results",
12+
"./tests/e2e/.auth"
13+
]
714
},
815
"formatter": {
916
"enabled": true,

frontend/app/package-lock.json

Lines changed: 52 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/app/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@
115115
"postcss": "^8.4.23",
116116
"react-test-renderer": "^18.2.0",
117117
"tailwindcss": "^3.4.3",
118-
"ts-node": "^10.9.2",
119118
"typescript": "^5.5.3",
120119
"vitest": "^1.4.0"
121120
},

frontend/app/src/screens/layout/breadcrumb-navigation/items/breadcrumb-object-selector.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ const ObjectSelector = ({
3939
if (error) return null;
4040

4141
const objectList = data?.[schema.kind!].edges.map((edge: any) => edge.node);
42+
if (!objectList || objectList.length === 0) return null;
43+
4244
const currentObject = objectList.find((node: any) => node.id === id);
4345

4446
if (!currentObject) return null;

frontend/app/tests/e2e/proposed-changes/proposed-changes.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ test.describe("/proposed-changes", () => {
101101
await page.getByRole("button", { name: "Save" }).click();
102102
await expect(page.getByText("ProposedChange updated")).toBeVisible();
103103

104-
await expect(page.getByRole("heading", { name: pcNameEdit })).toBeVisible();
104+
await expect(page.getByRole("heading", { name: pcNameEdit, exact: true })).toBeVisible();
105105
await expect(page.getByTestId("pc-description")).toContainText("My description edit");
106106
await expect(page.getByText("ReviewersAT")).toBeVisible();
107107
});

0 commit comments

Comments
 (0)