Display generic relationships with cardinality one in the object detail view (#6589)

Author: bilalabbad

changelog/+generic-one.fixed.md

@@ -0,0 +1 @@
+Display generic relationships with cardinality one in the object detail view.

docs/docs/topics/schema.mdx

@@ -169,7 +169,7 @@ The `kind` of a model is generated by concatenating the `namespace` and the `nam
 
   | ID                        | cardinality | Display in  List View | Display in  Detailed View | Display in Tab |
   | ------------------------- | ----------- | --------------------- | ------------------------- | -------------- |
-  | `Generic`                 | `one`       | No                    | No                       | Yes             |
+  | `Generic`                 | `one`       | No                    | Yes                       | No             |
   | `Generic`                 | `many`      | No                    | No                        | Yes            |
   | `Attribute`               | `one`       | Yes                   | Yes                       | No             |
   | `Attribute`               | `many`      | Yes                   | Yes                       | No             |

frontend/app/src/entities/nodes/object/utils/get-relationships-visible-in-detailed-view.test.ts

@@ -26,6 +26,20 @@ describe("getRelationshipsVisibleInDetailedView", () => {
     expect(result).toEqual(relationships);
   });
 
+  it("should return only Generic relationships with cardinality 'one'", () => {
+    // GIVEN
+    const relationships = [
+      generateRelationshipSchema({ kind: "Generic", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Generic", cardinality: "many" }),
+    ];
+
+    // WHEN
+    const result = getRelationshipsVisibleInDetailedView(relationships);
+
+    // THEN
+    expect(result).toEqual([generateRelationshipSchema({ kind: "Generic", cardinality: "one" })]);
+  });
+
   it("should return only Component relationships with cardinality 'one'", () => {
     // GIVEN
     const relationships = [
@@ -54,10 +68,10 @@ describe("getRelationshipsVisibleInDetailedView", () => {
     expect(result).toEqual([generateRelationshipSchema({ kind: "Hierarchy", cardinality: "one" })]);
   });
 
-  it("should not return other relationship types", () => {
+  it("should not return Group relationship types", () => {
     // GIVEN
     const relationships = [
-      generateRelationshipSchema({ kind: "Generic", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Group", cardinality: "one" }),
       generateRelationshipSchema({ kind: "Group", cardinality: "many" }),
     ];
 
@@ -73,11 +87,13 @@ describe("getRelationshipsVisibleInDetailedView", () => {
     const relationships = [
       generateRelationshipSchema({ kind: "Attribute", cardinality: "many" }),
       generateRelationshipSchema({ kind: "Parent", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Generic", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Generic", cardinality: "many" }),
       generateRelationshipSchema({ kind: "Component", cardinality: "one" }),
       generateRelationshipSchema({ kind: "Component", cardinality: "many" }),
       generateRelationshipSchema({ kind: "Hierarchy", cardinality: "one" }),
       generateRelationshipSchema({ kind: "Hierarchy", cardinality: "many" }),
-      generateRelationshipSchema({ kind: "Generic", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Group", cardinality: "many" }),
     ];
 
     // WHEN
@@ -87,6 +103,7 @@ describe("getRelationshipsVisibleInDetailedView", () => {
     expect(result).toEqual([
       generateRelationshipSchema({ kind: "Attribute", cardinality: "many" }),
       generateRelationshipSchema({ kind: "Parent", cardinality: "one" }),
+      generateRelationshipSchema({ kind: "Generic", cardinality: "one" }),
       generateRelationshipSchema({ kind: "Component", cardinality: "one" }),
       generateRelationshipSchema({ kind: "Hierarchy", cardinality: "one" }),
     ]);

frontend/app/src/entities/nodes/object/utils/get-relationships-visible-in-detailed-view.ts

@@ -10,6 +10,7 @@ export function getRelationshipsVisibleInDetailedView(
         return true;
       }
       case "Component":
+      case "Generic":
       case "Hierarchy": {
         return relationship.cardinality === "one";
       }