bug: Upsert mutation fails when one side of the relationship is optional

[BaptisteGi]

Component

Python SDK, API Server / GraphQL

Infrahub version

1.5.3

Current Behavior

When editing some data I get a upsert mutation exception ['LocationBuildingUpsert'] Node 1881bea1-7db4-f69f-3f7b-132df76881cc has -1 peers for stuff__building, no fewer than 1 allowed

Even tho the exception is raised, the data is still edited in the database, creating inconsistent data.

Expected Behavior

I except the mutation to fail and NOT EDIT data.

Steps to Reproduce

• Load the following schema

---
version: "1.0"

nodes:
  - name: Building
    namespace: Location
    icon: mdi:office-building
    include_in_menu: true
    human_friendly_id:
      - name__value
    display_label: name__value
    attributes:
      - name: name
        kind: Text
        unique: true

  - name: Stuff
    namespace: Random
    display_label: name__value
    human_friendly_id:
      - name__value
    attributes:
      - name: name
        kind: Text
        unique: true
    relationships:
      - name: building
        kind: Attribute
        peer: LocationBuilding
        cardinality: one
        optional: false
        identifier: stuff__building

extensions:
  nodes:
    - kind: LocationBuilding
      relationships:
        - name: stuff
          kind: Attribute
          peer: RandomStuff
          cardinality: one
          optional: true
          identifier: stuff__building

• Then load the current object file multiple times

---
apiVersion: infrahub.app/v1
kind: Object
spec:
  kind: LocationBuilding
  data:
    - name: BigBuilding

---
apiVersion: infrahub.app/v1
kind: Object
spec:
  kind: RandomStuff
  data:
    - name: FirstStuff
      building: BigBuilding

-> Raises this exception every other time

infrahubctl object load objects.yml
['LocationBuildingUpsert'] Node 1881bea1-7db4-f69f-3f7b-132df76881cc has -1 peers for stuff__building, no fewer than 1 allowed

-> After the failure you can see RandomStuff records in the database WITHOUT relationship to building, even tho it's a mandatory field

Additional Information

• The same behavior is present using frontend as well
• This prevents object files to be properly loaded using GIT integration

[BaptisteGi]

With 1.5.4 the part where some record could end up without a mandatory relationship is fixed. But I still can't load multiple time the above object file:

---
apiVersion: infrahub.app/v1
kind: Object
spec:
  kind: LocationBuilding
  data:
    - name: BigBuilding
      stuff:
        kind: RandomStuff
        data:
          name: FirstStuff

['LocationBuildingUpsert'] Node 18824b43-81e6-bb73-3626-10655482ccd0 has -1 peers for stuff__building, no fewer than 1 allowed

[minitriga]

I hit this bug yesterday

[ogenstad]

Running this using export INFRAHUB_ECHO_GRAPHQL_QUERIES=true we can observe the following

❯ infrahubctl object load ../models/baptiste-object.yml
URL: http://localhost:8000/graphql/main
QUERY:

mutation {
    LocationBuildingUpsert(
        data: {
            name: {
                value: "BigBuilding"
            }
            stuff: null
        }
    ){
        ok
        object {
            id
        }
    }
}

[17:24:50] INFO     Created node: BigBuilding                                                                                                                                                                                                                                                                                                                                                                                                                                     object.py:496
URL: http://localhost:8000/graphql/main
QUERY:

mutation {
    RandomStuffUpsert(
        data: {
            name: {
                value: "FirstStuff"
            }
            building: {
                hfid: [
                    "BigBuilding",
                ]
            }
        }
    ){
        ok
        object {
            id
        }
    }
}

[17:24:51] INFO     Created node: FirstStuff

Second run:

❯ infrahubctl object load ../models/baptiste-object.yml
URL: http://localhost:8000/graphql/main
QUERY:

mutation {
    LocationBuildingUpsert(
        data: {
            name: {
                value: "BigBuilding"
            }
            stuff: null
        }
    ){
        ok
        object {
            id
        }
    }
}

['LocationBuildingUpsert'] Node 1882aa84-8833-dce8-58d9-17462df7ab3b has -1 peers for stuff__building, no fewer than 1 allowed

Here we're sending a null value to the optional relationship stuff so on the first run it succeeds as we are able to create a LocationBuilding object without a relationship attached to stuff. However when we create the RandomStuff object we add this relationship. The next time we run this we try to update LocationBuilding and again try to set stuff to a null value i.e. we remove the relationship. In doing so the backend correctly rejects the mutation. It looks like the problem here is that the object loader within infrahubctl always tries to null out this relationship.

[ogenstad]

Ok it's not actually in the object load command but in the SDK node objects:

import os

from infrahub_sdk import InfrahubClientSync

os.environ["INFRAHUB_ECHO_GRAPHQL_QUERIES"] = "true"

client = InfrahubClientSync()

kind = 'LocationBuilding'

data = {'name': 'BigBuilding'}

node = client.create(kind=kind, data=data)
node.save(allow_upsert=True)

[minitriga]

Sounds similar to this @ogenstad opsmill/infrahub-sdk-python#634