Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Nov 8, 2024

Changes to tests

Due to the api/schema endpoint now triggering a workflow that requires the SDK client I moved some of the tests from unittest into the functional tests. At the same time I made some minor modifications to the format of the tests and also combined some of them as they seemed a bit redundant.

  • backend/tests/unit/api/test_40_schema_api.py the test_schema_load_endpoint_valid_simple() and test_schema_load_endpoint_idempotent_simple() tests have been combined into one TestLoadSchemaAPI::test_schema_load_endpoint_idempotent_simple()
  • backend/tests/unit/api/test_40_schema_api.py the test_schema_load_endpoint_valid_with_generics() and test_schema_load_endpoint_idempotent_with_generics() have been combined into TestLoadSchemaAPI::test_schema_load_endpoint_idempotent_with_generics()
  • backend/tests/unit/api/test_40_schema_api.py converted test_schema_load_endpoint_valid_with_extensions into `TestLoadSchemaAPI::test_schema_load_endpoint_valid_with_extensions()``
  • With regards to the migrated unittests from test_40_schema_api I also simplified them a bit so that all information they need is contained within the json files being loaded instead of loading various other fixtures first.
  • backend/tests/unit/api/test_20_schema_api.py. Migrated test_query_at_previous_schema() into TestPreviousVersions::test_query_at_previous_schema()

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 8, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #4894 will not alter performance

Comparing pog-computed-attribute-transform-automations (aee8aad) with develop (f12135d)

Summary

✅ 10 untouched benchmarks

@ogenstad ogenstad force-pushed the pog-computed-attribute-transform-automations branch 2 times, most recently from c9b9f82 to 92c56a6 Compare November 10, 2024 19:13
@ogenstad ogenstad force-pushed the pog-computed-attribute-transform-automations branch 5 times, most recently from 5049a42 to 14e064c Compare November 12, 2024 15:27
@ogenstad ogenstad marked this pull request as ready for review November 13, 2024 05:41
@ogenstad ogenstad requested a review from a team November 13, 2024 09:41
@ogenstad ogenstad force-pushed the pog-computed-attribute-transform-automations branch from 14e064c to aee8aad Compare November 13, 2024 11:37
@ogenstad ogenstad merged commit 1a887dc into develop Nov 13, 2024
32 checks passed
@ogenstad ogenstad deleted the pog-computed-attribute-transform-automations branch November 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants