Added some functional tests.

Author: fabiankessler

src/test/functional/java/org/nameapi/client/services/development/exceptionthrower/ExceptionThrowerCommandTest.java

@@ -12,6 +12,7 @@
 import org.testng.annotations.Test;
 
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.fail;
 
 /**
@@ -31,15 +32,27 @@ public void testCall1() throws Exception {
         }
     }
 
-    @Test(expectedExceptions = InternalServerErrorServiceException.class)
+    @Test
     public void testCall2() throws Exception {
-        execute(ExceptionType.InternalServerError);
+        try {
+            execute(ExceptionType.InternalServerError);
+            fail("Expected exception!");
+        } catch (InternalServerErrorServiceException e) {
+            assertEquals(e.getFaultInfo().getBlame(), Blame.SERVER);
+            assertFalse(e.getFaultInfo().getRetrySameLocation().isPresent());
+        }
     }
 
 
-    @Test(expectedExceptions = AccessDeniedServiceException.class)
+    @Test
     public void testCall3() throws Exception {
-        execute(ExceptionType.AccessDeniedNoSuchAccount);
+        try {
+            execute(ExceptionType.AccessDeniedNoSuchAccount);
+            fail("Expected exception!");
+        } catch (AccessDeniedServiceException e) {
+            assertEquals(e.getFaultInfo().getBlame(), Blame.CLIENT);
+            assertEquals(e.getFaultInfo().getRetrySameLocation().get().getRetryType(), RetryType.NO);
+        }
     }
 
 //    @Test(expectedExceptions = AccessDeniedServiceException.class)

src/test/functional/java/org/nameapi/client/services/email/disposableemailaddressdetector/DisposableEmailAddressDetectorCommandTest.java

@@ -17,9 +17,16 @@ public class DisposableEmailAddressDetectorCommandTest {
 
 
     @Test
-    public void testCall() throws Exception {
+    public void yes_1() throws Exception {
         DisposableEmailAddressDetectorCommand command = new DisposableEmailAddressDetectorCommand();
         Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
         assertEquals(executor.execute(command, mode, "[email protected]").get().getDisposable(), Maybe.YES);
     }
+
+    @Test
+    public void no_1() throws Exception {
+        DisposableEmailAddressDetectorCommand command = new DisposableEmailAddressDetectorCommand();
+        Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
+        assertEquals(executor.execute(command, mode, "[email protected]").get().getDisposable(), Maybe.NO);
+    }
 }

src/test/functional/java/org/nameapi/client/services/genderizer/persongenderizer/PersonGenderizerCommandTest.java

@@ -12,10 +12,12 @@
 import org.nameapi.ontology5.input.entities.person.NaturalInputPersonBuilder;
 import org.nameapi.ontology5.input.entities.person.age.AgeInfoFactory;
 import org.nameapi.ontology5.input.entities.person.gender.ComputedPersonGender;
+import org.nameapi.ontology5.input.entities.person.gender.StoragePersonGender;
 import org.nameapi.ontology5.services.genderizer.GenderizerResult;
 import org.testng.annotations.Test;
 
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.fail;
 
 /**
  */
@@ -75,16 +77,21 @@ public void testCall3() throws Exception {
         assertEquals(result.getGender(), ComputedPersonGender.MALE);
     }
 
-//    /**
-//     * Passing the gender is invalid because if it's already known it can only be validated (use another service).
-//     */
-//    @Test(expectedExceptions = InvalidInputServiceException.class)
-//    public void testCall_ex() throws Exception {
-//        PersonGenderizerCommand command = new PersonGenderizerCommand();
-//        Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
-//        NaturalInputPerson person = new NaturalInputPersonBuilder().name(makeName("John", "Doe"))
-//                .gender(StoragePersonGender.MALE)
-//        .build();
-//        executor.execute(command, mode, person);
-//    }
+    /**
+     * Passing the gender is invalid because if it's already known it can only be validated (use another service).
+     */
+    @Test
+    public void testCall_ex() throws Exception {
+        PersonGenderizerCommand command = new PersonGenderizerCommand();
+        Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
+        NaturalInputPerson person = new NaturalInputPersonBuilder().name(makeName("John", "Doe"))
+                .gender(StoragePersonGender.MALE)
+        .build();
+        try {
+            executor.execute(command, mode, person);
+            fail("Expected to get an exception!");
+        } catch (Exception e) {
+            //currently InternalServerErrorServiceException, something like InvalidInputServiceException would be better suited.
+        }
+    }
 }

src/test/functional/java/org/nameapi/client/services/matcher/personmatcher/PersonMatcherCommandTest.java

@@ -31,7 +31,7 @@ public void test_equal() throws Exception {
     }
 
     @Test
-    public void test_matching() throws Exception {
+    public void test_matching_1() throws Exception {
         PersonMatcherCommand command = new PersonMatcherCommand();
         Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
         NaturalInputPerson person1 = new NaturalInputPersonBuilder().name(makeName("Petra Müller")).build();
@@ -41,4 +41,15 @@ public void test_matching() throws Exception {
         assertEquals(result.getMatchType(), PersonMatchType.MATCHING);
     }
 
+    @Test
+    public void test_matching_2() throws Exception {
+        PersonMatcherCommand command = new PersonMatcherCommand();
+        Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
+        NaturalInputPerson person1 = new NaturalInputPersonBuilder().name(makeName("Petra K. Müller")).build();
+        NaturalInputPerson person2 = new NaturalInputPersonBuilder().name(makeName("Petra Mueller-Meyer")).build();
+        PersonMatcherArgument argument = new PersonMatcherArgument(person1, person2);
+        PersonMatcherResult result = executor.execute(command, mode, argument).get();
+        assertEquals(result.getMatchType(), PersonMatchType.MATCHING);
+    }
+
 }