Skip to content

Commit ff3cce3

Browse files
committed
Renamed new result class to be consistent.
1 parent b163ce4 commit ff3cce3

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailAddressParsingResultType2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package org.nameapi.client.services.email.emailnameparser2;
33

44
/**
5-
* Belongs to {@link org.nameapi.client.services.email.emailnameparser2.EmailNameParserResult}, tells what was detected.
5+
* Belongs to {@link EmailNameParser2Result}, tells what was detected.
66
*
77
* Difference to the EmailAddressParsingResultType:
88
* The enum uses FUNCTIONAL instead of DEPARTMENT and TECHNICAL because the two can hardly be told apart.

src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParser2Command.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
* </p>
4242
*/
4343
public class EmailNameParser2Command
44-
extends NameApiBaseCommand<SoapEmailNameParser2, String, EmailNameParserResult>
44+
extends NameApiBaseCommand<SoapEmailNameParser2, String, EmailNameParser2Result>
4545
{
4646

4747
private static final String servicePath = "/email/emailnameparser2";
@@ -51,18 +51,18 @@ public EmailNameParser2Command() {
5151
}
5252

5353
@Override @NotNull
54-
public EmailNameParserResult call(@NotNull Optional<String> arg, @NotNull ExecutionContext ec) throws Exception {
54+
public EmailNameParser2Result call(@NotNull Optional<String> arg, @NotNull ExecutionContext ec) throws Exception {
5555
SoapEmailNameParserResult2 soapResult = getPort(ec).parse(getContext(ec), arg.get());
5656
return convert(soapResult);
5757
}
5858

5959
@NotNull
60-
private EmailNameParserResult convert(@NotNull SoapEmailNameParserResult2 soapResult) {
60+
private EmailNameParser2Result convert(@NotNull SoapEmailNameParserResult2 soapResult) {
6161
List<EmailNameParserMatch> matches = new ArrayList<>();
6262
for (SoapEmailNameParserMatch soapMatch : soapResult.getMatches()) {
6363
matches.add( convert(soapMatch) );
6464
}
65-
return new EmailNameParserResultImpl(soapResult.getResultType(), matches);
65+
return new EmailNameParser2ResultImpl(soapResult.getResultType(), matches);
6666
}
6767
@NotNull
6868
private EmailNameParserMatch convert(@NotNull SoapEmailNameParserMatch soapMatch) {

src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParserResult.java renamed to src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParser2Result.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
/**
1111
*/
12-
public interface EmailNameParserResult {
12+
public interface EmailNameParser2Result {
1313

1414
@NotNull
1515
EmailAddressParsingResultType2 getResultType();

src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParserResultImpl.java renamed to src/main/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParser2ResultImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.google.common.base.Optional;
44
import crema.annotation.Immutable;
55
import org.jetbrains.annotations.NotNull;
6-
import org.nameapi.client.services.email.emailnameparser.EmailAddressParsingResultType;
76
import org.nameapi.client.services.email.emailnameparser.EmailNameParserMatch;
87

98
import java.util.Collections;
@@ -12,14 +11,14 @@
1211
/**
1312
*/
1413
@Immutable
15-
class EmailNameParserResultImpl implements EmailNameParserResult {
14+
class EmailNameParser2ResultImpl implements EmailNameParser2Result {
1615

1716
@NotNull
1817
private final EmailAddressParsingResultType2 resultType;
1918
@NotNull
2019
private final List<EmailNameParserMatch> matches;
2120

22-
EmailNameParserResultImpl(@NotNull EmailAddressParsingResultType2 resultType, @NotNull List<EmailNameParserMatch> matches) {
21+
EmailNameParser2ResultImpl(@NotNull EmailAddressParsingResultType2 resultType, @NotNull List<EmailNameParserMatch> matches) {
2322
this.resultType = resultType;
2423
this.matches = Collections.unmodifiableList(matches);
2524
}

src/test/functional/java/org/nameapi/client/services/email/emailnameparser2/EmailNameParser2CommandTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import com.optimaize.command4j.Mode;
55
import org.nameapi.client.lib.NameApiRemoteExecutors;
66
import org.nameapi.client.services.FunctionalTestsNameApiModeFactory;
7-
import org.nameapi.client.services.email.emailnameparser.EmailAddressParsingResultType;
87
import org.testng.annotations.Test;
98

109
import static org.testng.Assert.assertEquals;
@@ -19,7 +18,7 @@ public class EmailNameParser2CommandTest {
1918
public void testParse_John_Doe() throws Exception {
2019
EmailNameParser2Command command = new EmailNameParser2Command();
2120
Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
22-
EmailNameParserResult result = executor.execute(command, mode, "[email protected]").get();
21+
EmailNameParser2Result result = executor.execute(command, mode, "[email protected]").get();
2322
assertEquals(result.getResultType(), EmailAddressParsingResultType2.PERSON_NAME);
2423
assertEquals(result.getBestNameMatch().get().getGivenNames().get(0).getName(), "john");
2524
assertEquals(result.getBestNameMatch().get().getSurnames().get(0).getName(), "doe");
@@ -29,7 +28,7 @@ public void testParse_John_Doe() throws Exception {
2928
public void testParse_webmaster() throws Exception {
3029
EmailNameParser2Command command = new EmailNameParser2Command();
3130
Mode mode = FunctionalTestsNameApiModeFactory.functionalTest();
32-
EmailNameParserResult result = executor.execute(command, mode, "[email protected]").get();
31+
EmailNameParser2Result result = executor.execute(command, mode, "[email protected]").get();
3332
assertEquals(result.getResultType(), EmailAddressParsingResultType2.FUNCTIONAL);
3433
}
3534

0 commit comments

Comments
 (0)