Context attributes TextCase and Priority are now enums.

Author: fabiankessler

src/org/nameapi/ontology/input/context/Priority.php

@@ -2,10 +2,42 @@
 
 namespace org\nameapi\ontology\input\context;
 
-class Priority {
-    const __default = 'REALTIME';
-    const REALTIME = 'REALTIME';
-    const LOW = 'LOW';
+/**
+ * Class Priority
+ *
+ * Possible values are: REALTIME, LOW
+ */
+final class Priority {
 
+    private static $realtime = null;
+    private static $low = null;
+
+    public static function REALTIME() {
+        if (!Priority::$realtime) Priority::$realtime = new Priority('REALTIME');
+        return Priority::$realtime;
+    }
+    public static function LOW() {
+        if (!Priority::$low) Priority::$low = new Priority('LOW');
+        return Priority::$low;
+    }
+
+
+    /**
+     * @var string $value
+     */
+    private $value = null;
+
+    public function __construct($value) {
+        if ($value!=='REALTIME' && $value!=='LOW') {
+            throw new \Exception('Invalid value for Priority: '.$value.'!');
+        }
+        $this->value = $value;
+    }
+
+
+    public function __toString() {
+        return $this->value;
+    }
 
 }
+

src/org/nameapi/ontology/input/context/TextCase.php

@@ -2,11 +2,47 @@
 
 namespace org\nameapi\ontology\input\context;
 
-class TextCase {
-  const __default = 'TITLE_CASE';
-  const TITLE_CASE = 'TITLE_CASE';
-  const UPPER_CASE = 'UPPER_CASE';
-  const LOWER_CASE = 'LOWER_CASE';
+/**
+ * Class Priority
+ *
+ * Possible values are: TITLE_CASE, UPPER_CASE, LOWER_CASE
+ */
+final class TextCase {
 
+    private static $titleCase = null;
+    private static $upperCase = null;
+    private static $lowerCase = null;
+
+    public static function TITLE_CASE() {
+        if (!TextCase::$titleCase) TextCase::$titleCase = new TextCase('TITLE_CASE');
+        return TextCase::$titleCase;
+    }
+    public static function UPPER_CASE() {
+        if (!TextCase::$upperCase) TextCase::$upperCase = new TextCase('UPPER_CASE');
+        return TextCase::$upperCase;
+    }
+    public static function LOWER_CASE() {
+        if (!TextCase::$lowerCase) TextCase::$lowerCase = new TextCase('LOWER_CASE');
+        return TextCase::$lowerCase;
+    }
+
+    /**
+     * @var string $value
+     */
+    private $value = null;
+
+    public function __construct($value) {
+        if ($value!=='TITLE_CASE' && $value!=='UPPER_CASE' && $value!=='LOWER_CASE') {
+            throw new \Exception('Invalid value for TextCase: '.$value.'!');
+        }
+        $this->value = $value;
+    }
+
+
+    public function __toString() {
+        return $this->value;
+    }
 
 }
+
+

tests/functional/org/nameapi/client/services/BaseServiceTest.php

@@ -25,8 +25,8 @@ protected function makeContext() {
         }
         return Context::builder()
             ->apiKey($this->apiKey)
-            ->priority(Priority::REALTIME)
-            ->textCase(TextCase::TITLE_CASE)
+            ->priority(Priority::REALTIME())
+            ->textCase(TextCase::TITLE_CASE())
             ->build();
     }
 
@@ -37,4 +37,4 @@ protected function makeServiceFactory() {
         return new ServiceFactory($this->makeContext());
     }
 
-} 
+}

tests/unit/org/nameapi/ontology/input/context/ContextBuilderTest.php

@@ -7,10 +7,10 @@
 class ContextBuilderTest extends \PHPUnit_Framework_TestCase {
 
     public function testOne() {
-        $context = Context::builder()->apiKey('my-api-key')->geo('DE')->priority(Priority::REALTIME)->build();
+        $context = Context::builder()->apiKey('my-api-key')->geo('DE')->priority(Priority::REALTIME())->build();
         $this->assertEquals('my-api-key', $context->getApiKey());
         $this->assertEquals('DE', $context->getGeo());
-        $this->assertEquals(Priority::REALTIME, $context->getPriority());
+        $this->assertEquals(Priority::REALTIME(), $context->getPriority());
         $this->assertEquals(array(), $context->getProperties());
     }
 

tests/unit/org/nameapi/ontology/input/context/PriorityTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace org\nameapi\ontology\input\context;
+
+require_once(__DIR__.'/../../../../../../../src/org/nameapi/ontology/input/context/Priority.php');
+
+class PriorityTest extends \PHPUnit_Framework_TestCase {
+
+    public function testEquality() {
+        $this->assertEquals(Priority::REALTIME(), Priority::REALTIME());
+        $this->assertTrue(Priority::REALTIME() === Priority::REALTIME());
+        $this->assertEquals('REALTIME', (string)Priority::REALTIME());
+    }
+
+}
+

tests/unit/org/nameapi/ontology/input/context/TextCaseTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace org\nameapi\ontology\input\context;
+
+require_once(__DIR__.'/../../../../../../../src/org/nameapi/ontology/input/context/TextCase.php');
+
+class TextCaseTest extends \PHPUnit_Framework_TestCase {
+
+    public function testEquality() {
+        $this->assertEquals(TextCase::TITLE_CASE(), TextCase::TITLE_CASE());
+        $this->assertTrue(TextCase::TITLE_CASE() === TextCase::TITLE_CASE());
+        $this->assertEquals('TITLE_CASE', (string)TextCase::TITLE_CASE());
+    }
+
+}
+