Skip to content

Commit 51086d5

Browse files
committed
Null default values to allow type hinting. Import cleanup.
1 parent 91e935e commit 51086d5

File tree

10 files changed

+3
-17
lines changed

10 files changed

+3
-17
lines changed

src/org/nameapi/client/fault/FaultInfo.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class FaultInfo
6565
* @param Retry $retrySameLocation
6666
* @param Retry $retryOtherLocations
6767
*/
68-
public function __construct($faultCause, $blame, $message, $applicationErrorCode, $incidentId, Retry $retrySameLocation, Retry $retryOtherLocations)
68+
public function __construct($faultCause, $blame, $message, $applicationErrorCode=null, $incidentId=null, Retry $retrySameLocation=null, Retry $retryOtherLocations=null)
6969
{
7070
$this->faultCause = $faultCause;
7171
$this->blame = $blame;

src/org/nameapi/client/fault/Retry.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static function no() {
2727
* @param RetryType $retryType
2828
* @param int $retryInSeconds
2929
*/
30-
public function __construct(RetryType $retryType, $retryInSeconds)
30+
public function __construct(RetryType $retryType, $retryInSeconds=null)
3131
{
3232
$this->retryType = $retryType;
3333
$this->retryInSeconds = $retryInSeconds;

src/org/nameapi/client/fault/ServiceException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ServiceException extends Exception {
3232
* @param HttpResponseData $httpData
3333
* @param Exception $cause
3434
*/
35-
public function __construct($message, FaultInfo $faultInfo, HttpResponseData $httpData, $cause=null) {
35+
public function __construct($message, FaultInfo $faultInfo=null, HttpResponseData $httpData=null, $cause=null) {
3636
parent::__construct($message, 0, $cause);
3737
$this->faultInfo = $faultInfo;
3838
$this->httpData = $httpData;

src/org/nameapi/client/services/email/disposableemailaddressdetector/DisposableEmailAddressDetectorService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\email\disposableemailaddressdetector;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\ontology\input\context\Context;
108

src/org/nameapi/client/services/email/emailnameparser/EmailNameParserService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\email\emailnameparser;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\ontology\input\context\Context;
108

src/org/nameapi/client/services/formatter/namefieldformatter/NameFieldFormatterService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
namespace org\nameapi\client\services\formatter\namefieldformatter;
44

5-
use org\nameapi\client\http\RestHttpClient;
6-
use org\nameapi\client\http\RestHttpClientConfig;
75
use org\nameapi\client\services\BaseService;
86
use org\nameapi\client\services\formatter\FormatterProperties;
97
use org\nameapi\client\services\formatter\FormatterResult;

src/org/nameapi/client/services/formatter/personnameformatter/PersonNameFormatterService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\formatter\personnameformatter;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\client\services\formatter\FormatterProperties;
108
use org\nameapi\client\services\formatter\FormatterResult;

src/org/nameapi/client/services/genderizer/persongenderizer/PersonGenderizerService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\genderizer\persongenderizer;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\ontology\input\context\Context;
108
use org\nameapi\ontology\input\entities\person\gender\ComputedPersonGender;

src/org/nameapi/client/services/matcher/personmatcher/PersonMatcherService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\matcher\personmatcher;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\client\services\matcher\AgeMatcherResult;
108
use org\nameapi\client\services\matcher\AgeMatchType;

src/org/nameapi/client/services/parser/personnameparser/PersonNameParserService.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
namespace org\nameapi\client\services\parser\personnameparser;
44

55
use org\nameapi\client\fault\ServiceException;
6-
use org\nameapi\client\http\RestHttpClient;
7-
use org\nameapi\client\http\RestHttpClientConfig;
86
use org\nameapi\client\services\BaseService;
97
use org\nameapi\client\services\parser\OutputPersonName;
108
use org\nameapi\client\services\parser\OutputTermType;

0 commit comments

Comments
 (0)