Use getter/setter

Author: shuds13

optimas/core/trial.py

@@ -94,7 +94,7 @@ def to_dict(self) -> Dict:
         }
 
         if hasattr(self, "_ax_trial_id"):
-            trial_dict["ax_trial_id"] = self._ax_trial_id
+            trial_dict["ax_trial_id"] = self.ax_trial_id
 
         return trial_dict
 
@@ -123,6 +123,7 @@ def from_dict(
             Additional parameters needed to identify or carry out the trial, and
             which will be included in the optimization history.
         """
+
         # Prepare values of the input parameters
         parameter_values = [trial_dict[var.name] for var in varying_parameters]
         # Prepare evaluations
@@ -152,6 +153,7 @@ def from_dict(
             trial._status = trial_dict["_status"]
         for custom_param in custom_parameters:
             setattr(trial, custom_param.name, trial_dict[custom_param.name])
+
         return trial
 
     @property
@@ -202,6 +204,15 @@ def index(self) -> int:
     def index(self, value):
         self._index = value
 
+    @property
+    def ax_trial_id(self) -> int:
+        """Get the index of the trial."""
+        return self._ax_trial_id
+
+    @ax_trial_id.setter
+    def ax_trial_id(self, value):
+        self._ax_trial_id = value
+
     @property
     def ignored(self) -> bool:
         """Get whether the trial is ignored by the generator."""

optimas/generators/ax/service/base.py

@@ -168,7 +168,7 @@ def ingest(self, results: List[dict]) -> None:
                 custom_parameters=self._custom_trial_parameters,
             )
             try:
-                trial_id = trial.ax_trial_id
+                trial_id = trial._ax_trial_id
                 ax_trial = self._ax_client.get_trial(trial_id)
             except AttributeError:
                 params = {}