Skip to content

Commit 63a7fe1

Browse files
mnoman09thomaszurkan-optimizely
authored andcommitted
Changes CDN URL of datafile and edits Unit tests related to it (#190)
1 parent aa4771d commit 63a7fe1

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

android-sdk/src/androidTest/java/com/optimizely/ab/android/sdk/OptimizelyManagerTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void initializeInt() {
110110

111111
assertEquals(optimizelyManager.isDatafileCached(InstrumentationRegistry.getTargetContext()), false);
112112

113-
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/public/1/datafile_v3.json" );
113+
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/json/1.json" );
114114

115115
assertNotNull(optimizelyManager.getOptimizely());
116116
assertNotNull(optimizelyManager.getDatafileHandler());
@@ -126,7 +126,7 @@ public void initializeSync() {
126126

127127
assertEquals(optimizelyManager.isDatafileCached(InstrumentationRegistry.getTargetContext()), false);
128128

129-
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/public/1/datafile_v3.json" );
129+
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/json/1.json" );
130130

131131
assertNotNull(optimizelyManager.getOptimizely());
132132
assertNotNull(optimizelyManager.getDatafileHandler());
@@ -164,7 +164,7 @@ public void getDatafile() {
164164
*/
165165
assertEquals(optimizelyManager.isDatafileCached(InstrumentationRegistry.getTargetContext()), false);
166166
String datafile = optimizelyManager.getDatafile(InstrumentationRegistry.getTargetContext(), R.raw.datafile);
167-
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/public/1/datafile_v3.json" );
167+
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/json/1.json" );
168168
assertNotNull(datafile);
169169
assertNotNull(optimizelyManager.getDatafileHandler());
170170
}
@@ -185,7 +185,7 @@ public void onStart(OptimizelyClient optimizely) {
185185

186186
assertEquals(optimizelyManager.isDatafileCached(InstrumentationRegistry.getTargetContext()), false);
187187

188-
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/public/1/datafile_v3.json" );
188+
assertEquals(optimizelyManager.getDatafileUrl("1"), "https://cdn.optimizely.com/json/1.json" );
189189

190190

191191
}

datafile-handler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,9 @@ public void testIntentExtraData(){
207207
@Test
208208
public void testGetDatafileUrl(){
209209
// HARD-CODING link here to make sure we don't unintentionally mess up the datafile version
210-
// and url by accidentally changing those constants. Bumping datafile versions will force
210+
// and url by accidentally changing those constants.
211211
// us to update this test.
212212
String datafileUrl = DatafileService.getDatafileUrl("1");
213-
assertEquals("https://cdn.optimizely.com/public/1/datafile_v3.json", datafileUrl);
213+
assertEquals("https://cdn.optimizely.com/json/1.json", datafileUrl);
214214
}
215215
}

datafile-handler/src/main/java/com/optimizely/ab/android/datafile_handler/DatafileService.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ public class DatafileService extends Service {
4545
* Extra containing the project id this instance of Optimizely was built with
4646
*/
4747
public static final String EXTRA_PROJECT_ID = "com.optimizely.ab.android.EXTRA_PROJECT_ID";
48-
public static final String FORMAT_VERSIONED_CDN_URL = "https://cdn.optimizely.com/public/%s/datafile_v%s.json";
49-
static final String DATAFILE_VERSION = "3";
48+
public static final String FORMAT_VERSIONED_CDN_URL = "https://cdn.optimizely.com/json/%s.json";
5049
public static final Integer JOB_ID = 2113;
5150

5251
@NonNull private final IBinder binder = new LocalBinder();
@@ -110,7 +109,7 @@ public boolean isBound() {
110109
}
111110

112111
public static @NonNull String getDatafileUrl(@NonNull String projectId) {
113-
return String.format(FORMAT_VERSIONED_CDN_URL, projectId, DATAFILE_VERSION);
112+
return String.format(FORMAT_VERSIONED_CDN_URL, projectId);
114113
}
115114

116115
public void stop() {

0 commit comments

Comments
 (0)