Skip to content

Commit 97229ba

Browse files
author
Elliot Kim
committed
Fix for crash #4
Summary: Fix for crash #2 Test Plan: automated Reviewers: #oasis_team_review, mike.ng JIRA Issues: OASIS-1235 Differential Revision: https://phabricator.optimizely.com/D15711
1 parent 6a38c12 commit 97229ba

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@
4141
import com.optimizely.ab.android.shared.Client;
4242
import com.optimizely.ab.android.shared.OptlyStorage;
4343
import com.optimizely.ab.android.shared.ServiceScheduler;
44+
import com.optimizely.ab.android.user_profile.AndroidUserProfile;
4445
import com.optimizely.ab.bucketing.UserProfile;
4546
import com.optimizely.ab.config.parser.ConfigParseException;
4647
import com.optimizely.ab.event.internal.payload.Event;
47-
import com.optimizely.ab.android.user_profile.AndroidUserProfile;
4848

4949
import org.json.JSONObject;
5050
import org.slf4j.Logger;
@@ -157,7 +157,6 @@ public OptimizelyClient initialize(@NonNull Context context, @NonNull String dat
157157
logger.error("Unable to build OptimizelyClient instance", e);
158158
}
159159

160-
161160
// After instantiating the OptimizelyClient, we will begin the datafile sync so that next time
162161
// the user can instantiate with the latest datafile
163162
final Intent intent = new Intent(context.getApplicationContext(), DataFileService.class);
@@ -623,7 +622,13 @@ public Builder withDataFileDownloadInterval(long interval, @NonNull TimeUnit tim
623622
* @return a {@link Builder} instance
624623
*/
625624
public OptimizelyManager build() {
626-
final Logger logger = LoggerFactory.getLogger(OptimizelyManager.class);
625+
Logger logger;
626+
try {
627+
logger = LoggerFactory.getLogger(OptimizelyManager.class);
628+
} catch (Exception e) {
629+
logger = LoggerFactory.getLogger("Optly.androidSdk");
630+
logger.error("Unable to generate logger from class");
631+
}
627632

628633
// AlarmManager doesn't allow intervals less than 60 seconds
629634
if (dataFileDownloadIntervalTimeUnit.toMillis(dataFileDownloadInterval) < (60 * 1000)) {
@@ -640,7 +645,6 @@ public OptimizelyManager build() {
640645
dataFileDownloadIntervalTimeUnit,
641646
Executors.newSingleThreadExecutor(),
642647
logger);
643-
644648
}
645649
}
646650
}

0 commit comments

Comments
 (0)