Remove bound check in manager

Author: Josh Deffibaugh

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

@@ -429,21 +429,18 @@ public void onDataFileLoaded(@Nullable String dataFile) {
                         AlarmManager alarmManager = (AlarmManager) dataFileService.getApplicationContext().getSystemService(Context.ALARM_SERVICE);
                         ServiceScheduler.PendingIntentFactory pendingIntentFactory = new ServiceScheduler.PendingIntentFactory(dataFileService.getApplicationContext());
                         ServiceScheduler serviceScheduler = new ServiceScheduler(alarmManager, pendingIntentFactory, LoggerFactory.getLogger(ServiceScheduler.class));
-                        if (bound) {
-                            if (dataFile != null) {
-                                AndroidUserExperimentRecord userExperimentRecord =
-                                        (AndroidUserExperimentRecord) AndroidUserExperimentRecord.newInstance(optimizelyManager.getProjectId(), dataFileService.getApplicationContext());
-                                optimizelyManager.injectOptimizely(dataFileService.getApplicationContext(), userExperimentRecord, serviceScheduler, dataFile);
-                            } else {
-                                // We should always call the callback even with the dummy
-                                // instances.  Devs might gate the rest of their app
-                                // based on the loading of Optimizely
-                                OptimizelyStartListener optimizelyStartListener = optimizelyManager.getOptimizelyStartListener();
-                                if (optimizelyStartListener != null) {
-                                    optimizelyStartListener.onStart(optimizelyManager.getOptimizely());
-                                }
+                        if (dataFile != null) {
+                            AndroidUserExperimentRecord userExperimentRecord =
+                                    (AndroidUserExperimentRecord) AndroidUserExperimentRecord.newInstance(optimizelyManager.getProjectId(), dataFileService.getApplicationContext());
+                            optimizelyManager.injectOptimizely(dataFileService.getApplicationContext(), userExperimentRecord, serviceScheduler, dataFile);
+                        } else {
+                            // We should always call the callback even with the dummy
+                            // instances.  Devs might gate the rest of their app
+                            // based on the loading of Optimizely
+                            OptimizelyStartListener optimizelyStartListener = optimizelyManager.getOptimizelyStartListener();
+                            if (optimizelyStartListener != null) {
+                                optimizelyStartListener.onStart(optimizelyManager.getOptimizely());
                             }
-
                         }
                     }
                 });

android-sdk/src/test/java/com/optimizely/ab/android/sdk/OptimizelyManagerDataFileServiceConnectionTest.java

@@ -69,27 +69,6 @@ public void onServiceConnected() {
         verify(optimizelyManager).injectOptimizely(any(Context.class), any(AndroidUserExperimentRecord.class), any(ServiceScheduler.class), eq(""));
     }
 
-    @RequiresApi(api = Build.VERSION_CODES.HONEYCOMB)
-    @Test
-    public void onServiceConnectedNotBoundWhenDataFileLoaded() {
-        DataFileService.LocalBinder binder = mock(DataFileService.LocalBinder.class);
-        DataFileService service = mock(DataFileService.class);
-        Context context = mock(Context.class);
-        when(service.getApplicationContext()).thenReturn(context);
-        when(binder.getService()).thenReturn(service);
-        when(optimizelyManager.getProjectId()).thenReturn("1");
-        ArgumentCaptor<DataFileLoadedListener> captor = ArgumentCaptor.forClass(DataFileLoadedListener.class);
-        dataFileServiceConnection.onServiceConnected(null, binder);
-        verify(service).getDataFile(same("1"), any(DataFileLoader.class), captor.capture());
-
-        dataFileServiceConnection.onServiceDisconnected(null);
-
-        DataFileLoadedListener listener = captor.getValue();
-        listener.onDataFileLoaded("");
-
-        verify(optimizelyManager, never()).injectOptimizely(any(Context.class), any(AndroidUserExperimentRecord.class), any(ServiceScheduler.class), eq(""));
-    }
-
     @RequiresApi(api = Build.VERSION_CODES.HONEYCOMB)
     @Test
     public void onServiceConnectedNullServiceFromBinder() {