Skip to content

Commit e4f2802

Browse files
authored
Add catch for errors when instantiating logger (#132)
* Update android-logger to 1.3.6
1 parent f297b0c commit e4f2802

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,17 @@ public class OptimizelyManager {
5656

5757
@NonNull private OptimizelyClient optimizelyClient = new OptimizelyClient(null,
5858
LoggerFactory.getLogger(OptimizelyClient.class));
59-
@NonNull private final String projectId;
60-
@Nullable private OptimizelyStartListener optimizelyStartListener;
6159

60+
@NonNull private DatafileHandler datafileHandler;
6261
@NonNull private final long datafileDownloadInterval;
6362
@NonNull private final long eventDispatchInterval;
64-
65-
@Nullable private DatafileHandler datafileHandler = null;
66-
@Nullable private Logger logger = null;
6763
@Nullable private EventHandler eventHandler = null;
68-
@Nullable private ErrorHandler errorHandler = null;
69-
@Nullable private UserProfileService userProfileService = null;
64+
@NonNull private ErrorHandler errorHandler;
65+
@NonNull private Logger logger;
66+
@NonNull private final String projectId;
67+
@NonNull private UserProfileService userProfileService;
7068

69+
@Nullable private OptimizelyStartListener optimizelyStartListener;
7170

7271
OptimizelyManager(@NonNull String projectId,
7372
@NonNull Logger logger,
@@ -603,8 +602,11 @@ public OptimizelyManager build(Context context) {
603602
try {
604603
logger = LoggerFactory.getLogger(OptimizelyManager.class);
605604
} catch (Exception e) {
606-
logger = LoggerFactory.getLogger("Optly.androidSdk");
607-
logger.error("Unable to generate logger from class.");
605+
logger = LoggerFactory.getLogger("com.optimizely.ab.android.sdk.OptimizelyManager");
606+
logger.error("Unable to generate logger from class.", e);
607+
} catch (Error e) {
608+
logger = LoggerFactory.getLogger("com.optimizely.ab.android.sdk.OptimizelyManager");
609+
logger.error("Unable to generate logger from class.", e);
608610
}
609611
}
610612

android-sdk/src/main/resources/android-logger.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ logger.com.optimizely.ab.internal=DEBUG:Optly.internal
3333

3434
# Android
3535
logger.com.optimizely.ab.android.sdk=DEBUG:Optly.androidSdk
36+
logger.com.optimizely.ab.android.datafile_handler=DEBUG:Optly.datafileHandler
3637
logger.com.optimizely.ab.android.event_handler=DEBUG:Optly.eventHandler
3738
logger.com.optimizely.ab.android.shared=DEBUG:Optly.shared
3839
logger.com.optimizely.ab.android.user_profile=DEBUG:Optly.userProfile

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ ext {
5353
target_sdk_version = 24
5454

5555
java_core_ver = "1.7.0"
56-
android_logger_ver = "1.3.1"
56+
android_logger_ver = "1.3.6"
5757
support_annotations_ver = "24.2.1"
5858
junit_ver = "4.12"
5959
mockito_ver = "1.9.5"

0 commit comments

Comments
 (0)