Skip to content

Commit f985a79

Browse files
ODP for client only removed
1 parent f713de9 commit f985a79

File tree

4 files changed

+8
-197
lines changed

4 files changed

+8
-197
lines changed

odp/src/androidTest/java/com/optimizely/ab/android/odp/ODPSegmentClientTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
package com.optimizely.ab.android.odp
1616

1717
import androidx.test.ext.junit.runners.AndroidJUnit4
18-
import com.optimizely.ab.android.shared.ClientForODPOnly
18+
import com.optimizely.ab.android.shared.Client
1919
import java.io.OutputStream
2020
import java.net.HttpURLConnection
2121
import org.junit.Assert.assertNull
@@ -34,9 +34,9 @@ import org.slf4j.Logger
3434
@RunWith(AndroidJUnit4::class)
3535
class ODPSegmentClientTest {
3636
private val logger = mock(Logger::class.java)
37-
private val client = mock(ClientForODPOnly::class.java)
37+
private val client = mock(Client::class.java)
3838
private val urlConnection = mock(HttpURLConnection::class.java)
39-
private val captor = ArgumentCaptor.forClass(ClientForODPOnly.Request::class.java)
39+
private val captor = ArgumentCaptor.forClass(Client.Request::class.java)
4040
private lateinit var segmentClient: ODPSegmentClient
4141

4242
private val apiKey = "valid-key"

odp/src/main/java/com/optimizely/ab/android/odp/DefaultODPApiManager.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ package com.optimizely.ab.android.odp
1616

1717
import android.content.Context
1818
import androidx.annotation.VisibleForTesting
19-
import com.optimizely.ab.android.shared.ClientForODPOnly
19+
import com.optimizely.ab.android.shared.Client
2020
import com.optimizely.ab.android.shared.OptlyStorage
2121
import com.optimizely.ab.android.shared.WorkerScheduler
2222
import com.optimizely.ab.odp.ODPApiManager
@@ -33,7 +33,7 @@ open class DefaultODPApiManager(private val context: Context, timeoutForSegmentF
3333

3434
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
3535
var segmentClient = ODPSegmentClient(
36-
ClientForODPOnly(OptlyStorage(context), LoggerFactory.getLogger(ClientForODPOnly::class.java)),
36+
Client(OptlyStorage(context), LoggerFactory.getLogger(Client::class.java)),
3737
LoggerFactory.getLogger(ODPSegmentClient::class.java)
3838
)
3939
private val logger = LoggerFactory.getLogger(DefaultODPApiManager::class.java)

odp/src/main/java/com/optimizely/ab/android/odp/ODPSegmentClient.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
package com.optimizely.ab.android.odp
1616

1717
import androidx.annotation.VisibleForTesting
18-
import com.optimizely.ab.android.shared.ClientForODPOnly
18+
import com.optimizely.ab.android.shared.Client
1919
import com.optimizely.ab.odp.parser.ResponseJsonParser
2020
import com.optimizely.ab.odp.parser.ResponseJsonParserFactory
2121
import org.slf4j.Logger
2222
import java.net.HttpURLConnection
2323
import java.net.URL
2424

2525
@VisibleForTesting(otherwise = VisibleForTesting.PROTECTED)
26-
open class ODPSegmentClient(private val client: ClientForODPOnly, private val logger: Logger) {
26+
open class ODPSegmentClient(private val client: Client, private val logger: Logger) {
2727

2828
@VisibleForTesting(otherwise = VisibleForTesting.PROTECTED)
2929
open fun fetchQualifiedSegments(
@@ -32,7 +32,7 @@ open class ODPSegmentClient(private val client: ClientForODPOnly, private val lo
3232
payload: String
3333
): List<String>? {
3434

35-
val request: ClientForODPOnly.Request<String> = ClientForODPOnly.Request {
35+
val request: Client.Request<String> = Client.Request {
3636
var urlConnection: HttpURLConnection? = null
3737
try {
3838
val url = URL(apiEndpoint)

shared/src/main/java/com/optimizely/ab/android/shared/ClientForODPOnly.java

Lines changed: 0 additions & 189 deletions
This file was deleted.

0 commit comments

Comments
 (0)