bug: only SaveToUserProfileService if batch is finishing

mikechu-optimizely · mikechu-optimizely · commit 2b17438f535b · 2024-10-07T09:53:29.000-04:00
_decisionBatchInProgress from true to false
diff --git a/OptimizelySDK/Bucketing/DecisionService.cs b/OptimizelySDK/Bucketing/DecisionService.cs
@@ -49,14 +49,14 @@ public class DecisionService
 
         public bool DecisionBatchInProgress
         {
-            get => _decisionBatchInProgress;
             set
             {
-                _decisionBatchInProgress = value;
-                if (!_decisionBatchInProgress)
+                // Only save if the value is changing from true to false
+                if (_decisionBatchInProgress && !value)
                 {
                     SaveToUserProfileService();
                 }
+                _decisionBatchInProgress = value;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -49,14 +49,14 @@ public class DecisionService`
`49`	`49`
`50`	`50`	`public bool DecisionBatchInProgress`
`51`	`51`	`{`
`52`		`- get => _decisionBatchInProgress;`
`53`	`52`	`set`
`54`	`53`	`{`
`55`		`- _decisionBatchInProgress = value;`
`56`		`- if (!_decisionBatchInProgress)`
	`54`	`+ // Only save if the value is changing from true to false`
	`55`	`+ if (_decisionBatchInProgress && !value)`
`57`	`56`	`{`
`58`	`57`	`SaveToUserProfileService();`
`59`	`58`	`}`
	`59`	`+ _decisionBatchInProgress = value;`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`