[FSSDK-11546] experiment status "isRunning" logic simplified

Author: junaed-optimizely

OptimizelySDK.Tests/Assertions.cs

@@ -488,7 +488,7 @@ public static void AreEqual(Experiment expected, Experiment actual)
             Assert.AreEqual(expected.GroupId, actual.GroupId);
             Assert.AreEqual(expected.GroupPolicy, actual.GroupPolicy);
             Assert.AreEqual(expected.Id, actual.Id);
-            Assert.AreEqual(expected.IsExperimentRunning, actual.IsExperimentRunning);
+            Assert.AreEqual(expected.isRunning, actual.isRunning);
             Assert.AreEqual(expected.IsInMutexGroup, actual.IsInMutexGroup);
             Assert.AreEqual(expected.Key, actual.Key);
             Assert.AreEqual(expected.LayerId, actual.LayerId);
@@ -517,7 +517,7 @@ public static void AreEqual(ExperimentCore expected, ExperimentCore actual)
             Assert.AreEqual(expected.AudienceIdsList, actual.AudienceIdsList);
             Assert.AreEqual(expected.AudienceIdsString, actual.AudienceIdsString);
             Assert.AreEqual(expected.Id, actual.Id);
-            Assert.AreEqual(expected.IsExperimentRunning, actual.IsExperimentRunning);
+            Assert.AreEqual(expected.isRunning, actual.isRunning);
             Assert.AreEqual(expected.Key, actual.Key);
             Assert.AreEqual(expected.LayerId, actual.LayerId);
             Assert.AreEqual(expected.Status, actual.Status);

OptimizelySDK.Tests/EntityTests/HoldoutTests.cs

@@ -115,9 +115,6 @@ public void TestHoldoutEquality()
 
             Assert.IsNotNull(holdout1);
             Assert.IsNotNull(holdout2);
-            // Note: This test depends on how Holdout implements equality
-            // If Holdout doesn't override Equals, this will test reference equality
-            // You may need to implement custom equality logic for Holdout
         }
 
         [Test]
@@ -128,10 +125,6 @@ public void TestHoldoutStatusParsing()
 
             Assert.IsNotNull(globalHoldout);
             Assert.AreEqual("Running", globalHoldout.Status);
-
-            // Test that the holdout is considered activated when status is "Running"
-            // This assumes there's an IsActivated property or similar logic
-            // Adjust based on actual Holdout implementation
         }
 
         [Test]
@@ -184,9 +177,6 @@ public void TestHoldoutNullSafety()
             Assert.IsNotNull(holdout);
             Assert.AreEqual("test_holdout", holdout.Id);
             Assert.AreEqual("test_key", holdout.Key);
-
-            // Verify that missing includedFlags and excludedFlags are handled properly
-            // This depends on how the Holdout entity handles missing properties
             Assert.IsNotNull(holdout.IncludedFlags);
             Assert.IsNotNull(holdout.ExcludedFlags);
         }

OptimizelySDK/Bucketing/DecisionService.cs

@@ -910,7 +910,7 @@ ProjectConfig config
             var userId = user.GetUserId();
             var reasons = new DecisionReasons();
 
-            if (!holdout.IsActivated)
+            if (!holdout.isRunning)
             {
                 var infoMessage = $"Holdout \"{holdout.Key}\" is not running.";
                 Logger.Log(LogLevel.INFO, infoMessage);

OptimizelySDK/Entity/ExperimentCore.cs

@@ -276,9 +276,6 @@ public virtual Variation GetVariationByKey(string key)
         /// <summary>
         /// Determine if experiment is currently activated/running 
         /// </summary>
-        public bool IsExperimentRunning =>
-            !string.IsNullOrEmpty(Status) && Status == STATUS_RUNNING;
-
-        public bool IsActivated => IsExperimentRunning;
+        public bool isRunning => !string.IsNullOrEmpty(Status) && Status == STATUS_RUNNING;
     }
 }

OptimizelySDK/Optimizely.cs

@@ -1159,7 +1159,7 @@ private bool SendImpressionEvent(ExperimentCore experiment, Variation variation,
             string flagKey, string ruleType, bool enabled
         )
         {
-            if (experiment != null && !experiment.IsExperimentRunning)
+            if (experiment != null && !experiment.isRunning)
             {
                 Logger.Log(LogLevel.ERROR,
                     @"Experiment has ""Launched"" status so not dispatching event during activation.");

OptimizelySDK/Utils/ExperimentUtils.cs

@@ -25,7 +25,7 @@ public class ExperimentUtils
     {
         public static bool IsExperimentActive(Experiment experiment, ILogger logger)
         {
-            if (!experiment.IsExperimentRunning)
+            if (!experiment.isRunning)
             {
                 logger.Log(LogLevel.INFO, $"Experiment \"{experiment.Key}\" is not running.");