[FSSDK-11731] relative path approach

Author: junaed-optimizely

.github/workflows/csharp.yml

@@ -44,7 +44,7 @@ jobs:
         uses: microsoft/setup-msbuild@v1
       - name: Setup NuGet
         uses: NuGet/setup-nuget@v1
-      - name: Download and Install .NET Framework Reference Assemblies
+      - name: Download and Extract .NET Framework Reference Assemblies
         run: |
           # Create temp directory
           New-Item -ItemType Directory -Path "temp_ref_assemblies" -Force
@@ -57,33 +57,38 @@ jobs:
           echo "Downloading .NET 4.5 Reference Assemblies..."
           Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net45/1.0.3" -OutFile "temp_ref_assemblies/net45_ref.zip"
           
-          # Extract and install .NET 4.0
-          echo "Installing .NET 4.0 Reference Assemblies..."
+          # Extract .NET 4.0 Reference Assemblies
+          echo "Extracting .NET 4.0 Reference Assemblies..."
           Expand-Archive -Path "temp_ref_assemblies/net40_ref.zip" -DestinationPath "temp_ref_assemblies/net40" -Force
           if (Test-Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0") {
-              Copy-Item -Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
-              echo "✓ .NET 4.0 Reference Assemblies installed"
+              echo "✓ .NET 4.0 Reference Assemblies extracted to workspace"
           }
           
-          # Extract and install .NET 4.5
-          echo "Installing .NET 4.5 Reference Assemblies..."
+          # Extract .NET 4.5 Reference Assemblies
+          echo "Extracting .NET 4.5 Reference Assemblies..."
           Expand-Archive -Path "temp_ref_assemblies/net45_ref.zip" -DestinationPath "temp_ref_assemblies/net45" -Force
           if (Test-Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5") {
-              Copy-Item -Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
-              echo "✓ .NET 4.5 Reference Assemblies installed"
+              echo "✓ .NET 4.5 Reference Assemblies extracted to workspace"
           }
-          
-          # Cleanup
-          Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
       - name: Restore NuGet packages
         run: nuget restore ./OptimizelySDK.NETFramework.sln
       - name: Build & strongly name assemblies
-        run: msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.NETFramework.sln
+        run: |
+          # Build with workspace-relative reference assembly paths
+          $Net40RefPath = "$(pwd)\temp_ref_assemblies\net40\build\.NETFramework\v4.0"
+          $Net45RefPath = "$(pwd)\temp_ref_assemblies\net45\build\.NETFramework\v4.5"
+          
+          echo "Using .NET 4.0 Reference Assemblies from: $Net40RefPath"
+          echo "Using .NET 4.5 Reference Assemblies from: $Net45RefPath"
+          
+          msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release /p:FrameworkPathOverride="$Net45RefPath" ./OptimizelySDK.NETFramework.sln
       - name: Install & Run NUnit tests
         run: |
           nuget install NUnit.Console -Version 3.18.1 -DirectDownload -OutputDirectory .
           # https://docs.nunit.org/articles/nunit/running-tests/Console-Command-Line.html
           ./NUnit.ConsoleRunner.3.18.1\tools\nunit3-console.exe /timeout 10000 /process Separate ./OptimizelySDK.Tests/bin/Release/OptimizelySDK.Tests.dll
+      - name: Cleanup reference assemblies
+        run: Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
 
   netStandard16:
     name: Build Standard 1.6

.github/workflows/csharp_release.yml

@@ -41,7 +41,7 @@ jobs:
         uses: microsoft/setup-msbuild@v2
       - name: Setup NuGet
         uses: nuget/setup-nuget@v2
-      - name: Download and Install .NET Framework Reference Assemblies
+      - name: Download and Extract .NET Framework Reference Assemblies
         run: |
           # Create temp directory
           New-Item -ItemType Directory -Path "temp_ref_assemblies" -Force
@@ -54,28 +54,33 @@ jobs:
           echo "Downloading .NET 4.5 Reference Assemblies..."
           Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net45/1.0.3" -OutFile "temp_ref_assemblies/net45_ref.zip"
           
-          # Extract and install .NET 4.0
-          echo "Installing .NET 4.0 Reference Assemblies..."
+          # Extract .NET 4.0 Reference Assemblies
+          echo "Extracting .NET 4.0 Reference Assemblies..."
           Expand-Archive -Path "temp_ref_assemblies/net40_ref.zip" -DestinationPath "temp_ref_assemblies/net40" -Force
           if (Test-Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0") {
-              Copy-Item -Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
-              echo "✓ .NET 4.0 Reference Assemblies installed"
+              echo "✓ .NET 4.0 Reference Assemblies extracted to workspace"
           }
           
-          # Extract and install .NET 4.5
-          echo "Installing .NET 4.5 Reference Assemblies..."
+          # Extract .NET 4.5 Reference Assemblies
+          echo "Extracting .NET 4.5 Reference Assemblies..."
           Expand-Archive -Path "temp_ref_assemblies/net45_ref.zip" -DestinationPath "temp_ref_assemblies/net45" -Force
           if (Test-Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5") {
-              Copy-Item -Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
-              echo "✓ .NET 4.5 Reference Assemblies installed"
+              echo "✓ .NET 4.5 Reference Assemblies extracted to workspace"
           }
-          
-          # Cleanup
-          Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
       - name: Restore NuGet packages
         run: nuget restore ./OptimizelySDK.NETFramework.sln
       - name: Build and strongly name assemblies
-        run: msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.NETFramework.sln
+        run: |
+          # Build with workspace-relative reference assembly paths
+          $Net40RefPath = "$(pwd)\temp_ref_assemblies\net40\build\.NETFramework\v4.0"
+          $Net45RefPath = "$(pwd)\temp_ref_assemblies\net45\build\.NETFramework\v4.5"
+          
+          echo "Using .NET 4.0 Reference Assemblies from: $Net40RefPath"
+          echo "Using .NET 4.5 Reference Assemblies from: $Net45RefPath"
+          
+          msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release /p:FrameworkPathOverride="$Net45RefPath" ./OptimizelySDK.NETFramework.sln
+      - name: Cleanup reference assemblies
+        run: Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
       - name: Upload Framework artifacts
         uses: actions/upload-artifact@v4
         with: