fix: WIP tests & code under tests

Author: mikechu-optimizely

OptimizelySDK/Bucketing/DecisionService.cs

@@ -463,7 +463,15 @@ UserProfile userProfile
 
         public void AddDecisionToUnitOfWork(string userId, string experimentId, Decision decision)
         {
-            _decisionUnitOfWork.AddDecision(userId, experimentId, decision);
+            if (UserProfileService == null)
+            {
+                return;
+            }
+            
+            if (!string.IsNullOrEmpty(experimentId))
+            {
+                _decisionUnitOfWork.AddDecision(userId, experimentId, decision);
+            }
         }
 
         /// <summary>

OptimizelySDK/Bucketing/DecisionUnitOfWork.cs

@@ -25,6 +25,11 @@ public class DecisionUnitOfWork
 
         public void AddDecision(string userId, string experimentId, Decision decision)
         {
+            if (string.IsNullOrEmpty(userId) || string.IsNullOrEmpty(experimentId))
+            {
+                return;
+            }
+
             if (!_decisions.ContainsKey(userId))
             {
                 _decisions[userId] = new Dictionary<string, Decision>();

OptimizelySDK/Optimizely.cs

@@ -926,10 +926,9 @@ internal OptimizelyDecision Decide(OptimizelyUserContext user,
                 decisionReasons += flagDecisionResult.DecisionReasons;
                 decision = flagDecisionResult.ResultObject;
             }
-
-            // TODO: Fix when the flag is a rollout instead of an experiment
+            
             DecisionService.AddDecisionToUnitOfWork(userId, decision.Experiment?.Id,
-                new Decision(decision.Variation?.Id ?? ""));
+                new Decision(decision.Variation?.Id));
 
             var featureEnabled = false;