fix: tests & code under tests

Author: mikechu-optimizely

OptimizelySDK.Tests/OptimizelyUserContextTest.cs

@@ -61,7 +61,7 @@ public void SetUp()
             Optimizely = new Optimizely(TestData.Datafile, EventDispatcherMock.Object,
                 LoggerMock.Object, ErrorHandlerMock.Object);
         }
-        
+
         private Mock<UserProfileService> MakeUserProfileServiceMock()
         {
             var projectConfig = DatafileProjectConfig.Create(TestData.Datafile, LoggerMock.Object,
@@ -440,7 +440,7 @@ public void SeparateDecideShouldHaveSameNumberOfUpsSaveAndLookup()
             {
                 { "224", new Decision("280") },
                 { "122238", new Decision("122240") },
-            });            
+            });
             var flag2UserProfile = new UserProfile(UserID, new Dictionary<string, Decision>
             {
                 { "224", new Decision("280") },
@@ -531,7 +531,7 @@ public void DecideForKeysWithUpsShouldOnlyLookupSaveOnceWithMultipleFlags()
                 Times.Once);
             Assert.AreEqual(saveArgsCollector.First(), expectedUserProfile.ToMap());
         }
-        
+
         [Test]
         public void DecideForKeysWithOneFlag()
         {
@@ -561,11 +561,11 @@ public void DecideForKeysWithOneFlag()
                 new string[0]);
             Assert.IsTrue(TestData.CompareObjects(decision, expDecision));
         }
-        
+
         #endregion DecideForKeys
-        
+
         #region DecideAll
-        
+
         [Test]
         public void DecideAllWithUpsShouldOnlyLookupSaveOnce()
         {
@@ -595,8 +595,9 @@ public void DecideAllWithUpsShouldOnlyLookupSaveOnce()
                 l => l.Log(LogLevel.ERROR, "The UserProfileService returned an invalid map."),
                 Times.Never);
             userProfileServiceMock.Verify(l => l.Lookup(UserID), Times.Once);
-            userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string,object>>()), Times.Once);
-            Assert.AreEqual(saveArgsCollector.First(), expectedUserProfile.ToMap());    
+            userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string, object>>()),
+                Times.Once);
+            Assert.AreEqual(saveArgsCollector.First(), expectedUserProfile.ToMap());
         }
 
         [Test]
@@ -806,7 +807,7 @@ public void DecideAllAllFlags()
                 null,
                 flagKey10,
                 user,
-                new string[0]);
+                new[] { "Variable value for key \"any_key\" is invalid or wrong type." });
             Assert.IsTrue(TestData.CompareObjects(decisions[flagKey10], expDecision10));
         }
 

OptimizelySDK/Optimizely.cs

@@ -1040,7 +1040,8 @@ ProjectConfig projectConfig
                 decisionSource = flagDecision.Source;
             }
 
-            var reasonsToReport = decisionReasons.ToReport().ToArray();
+            var includeReasons= allOptions.Contains(OptimizelyDecideOption.INCLUDE_REASONS);
+            var reasonsToReport = decisionReasons.ToReport(includeReasons).ToArray();
             var variationKey = flagDecision.Variation?.Key;
             // TODO: add ruleKey values when available later. use a copy of experimentKey until then.
             //       add to event metadata as well (currently set to experimentKey)