Merge pull request #106 from optimizely/ali/feat_test

Moving experiment evaluation from CompositeFeatureService to FeatureExperimentService

Author: aliabbasrizvi

optimizely/decision/composite_feature_service.go

@@ -28,15 +28,15 @@ var cfLogger = logging.GetLogger("CompositeFeatureService")
 
 // CompositeFeatureService is the default out-of-the-box feature decision service
 type CompositeFeatureService struct {
-	experimentDecisionService ExperimentService
-	rolloutDecisionService    FeatureService
+	featureExperimentService ExperimentService
+	rolloutDecisionService   FeatureService
 }
 
 // NewCompositeFeatureService returns a new instance of the CompositeFeatureService
 func NewCompositeFeatureService() *CompositeFeatureService {
 	return &CompositeFeatureService{
-		experimentDecisionService: NewCompositeExperimentService(),
-		rolloutDecisionService:    NewRolloutService(),
+		featureExperimentService: NewFeatureExperimentService(),
+		rolloutDecisionService:   NewRolloutService(),
 	}
 }
 
@@ -45,15 +45,15 @@ func (f CompositeFeatureService) GetDecision(decisionContext FeatureDecisionCont
 	feature := decisionContext.Feature
 
 	// Check if user is bucketed in feature experiment
-	if f.experimentDecisionService != nil && len(feature.FeatureExperiments) > 0 {
+	if f.featureExperimentService != nil && len(feature.FeatureExperiments) > 0 {
 		// @TODO: add in a feature decision service that takes into account multiple experiments (via group mutex)
 		experiment := feature.FeatureExperiments[0]
 		experimentDecisionContext := ExperimentDecisionContext{
 			Experiment:    &experiment,
 			ProjectConfig: decisionContext.ProjectConfig,
 		}
 
-		experimentDecision, err := f.experimentDecisionService.GetDecision(experimentDecisionContext, userContext)
+		experimentDecision, err := f.featureExperimentService.GetDecision(experimentDecisionContext, userContext)
 		// Variation not nil means we got a decision and should return it
 		if experimentDecision.Variation != nil {
 			featureDecision := FeatureDecision{

optimizely/decision/feature_experiment_service.go

@@ -0,0 +1,37 @@
+/****************************************************************************
+ * Copyright 2019, Optimizely, Inc. and contributors                        *
+ *                                                                          *
+ * Licensed under the Apache License, Version 2.0 (the "License");          *
+ * you may not use this file except in compliance with the License.         *
+ * You may obtain a copy of the License at                                  *
+ *                                                                          *
+ *    http://www.apache.org/licenses/LICENSE-2.0                            *
+ *                                                                          *
+ * Unless required by applicable law or agreed to in writing, software      *
+ * distributed under the License is distributed on an "AS IS" BASIS,        *
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
+ * See the License for the specific language governing permissions and      *
+ * limitations under the License.                                           *
+ ***************************************************************************/
+
+// Package decision //
+package decision
+
+import (
+	"github.com/optimizely/go-sdk/optimizely/entities"
+)
+
+// FeatureExperimentService helps evaluate feature test associated with the feature
+type FeatureExperimentService struct {
+	featureExperimentService ExperimentService
+}
+
+// NewFeatureExperimentService returns a new instance of the FeatureExperimentService
+func NewFeatureExperimentService() *CompositeExperimentService {
+	return NewCompositeExperimentService()
+}
+
+// GetDecision returns a decision for the given feature test and user context
+func (f FeatureExperimentService) GetDecision(decisionContext ExperimentDecisionContext, userContext entities.UserContext) (ExperimentDecision, error) {
+	return f.featureExperimentService.GetDecision(decisionContext, userContext)
+}