fix: return right after datafile getter returns an error (don't parse garbage) (#170)

pawels-optimizely · web-flow · commit 56b8e594724d · 2019-11-07T15:09:25.000-08:00
diff --git a/pkg/config/polling_manager.go b/pkg/config/polling_manager.go
@@ -94,6 +94,8 @@ func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) {
 
 		if e != nil {
 			cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e)
+			cm.err = e
+			return
 		}
 	}
 
diff --git a/pkg/config/static_manager.go b/pkg/config/static_manager.go
@@ -41,6 +41,7 @@ func NewStaticProjectConfigManagerFromURL(sdkKey string) (*StaticProjectConfigMa
 	datafile, code, e := requester.Get()
 	if e != nil {
 		cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e)
+		return nil, e
 	}
 
 	return NewStaticProjectConfigManagerFromPayload(datafile)

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,8 @@ func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) {`
`94`	`94`
`95`	`95`	`if e != nil {`
`96`	`96`	`cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e)`
	`97`	`+ cm.err = e`
	`98`	`+ return`
`97`	`99`	`}`
`98`	`100`	`}`
`99`	`101`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ func NewStaticProjectConfigManagerFromURL(sdkKey string) (*StaticProjectConfigMa`
`41`	`41`	`datafile, code, e := requester.Get()`
`42`	`42`	`if e != nil {`
`43`	`43`	`cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e)`
	`44`	`+ return nil, e`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`return NewStaticProjectConfigManagerFromPayload(datafile)`