fix decide reasons issue for variables and reasons in fsc PR 495. (#309)

Author: yasirfolio3

pkg/client/optimizely_decision.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2020, Optimizely, Inc. and contributors                        *
+ * Copyright 2020-2021, Optimizely, Inc. and contributors                   *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -50,7 +50,7 @@ func NewErrorDecision(key string, user OptimizelyUserContext, err error) Optimiz
 	return OptimizelyDecision{
 		FlagKey:     key,
 		UserContext: user,
-		Variables:   &optimizelyjson.OptimizelyJSON{},
+		Variables:   optimizelyjson.NewOptimizelyJSONfromMap(map[string]interface{}{}),
 		Reasons:     []string{err.Error()},
 	}
 }

pkg/client/optimizely_decision_test.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2020, Optimizely, Inc. and contributors                        *
+ * Copyright 2020-2021, Optimizely, Inc. and contributors                   *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -67,7 +67,7 @@ func (s *OptimizelyDecisionTestSuite) TestNewErrorDecision() {
 
 	s.Equal("", decision.VariationKey)
 	s.Equal(false, decision.Enabled)
-	s.Equal(&optimizelyjson.OptimizelyJSON{}, decision.Variables)
+	s.Equal(optimizelyjson.NewOptimizelyJSONfromMap(map[string]interface{}{}), decision.Variables)
 	s.Equal("", decision.RuleKey)
 	s.Equal(flagKey, decision.FlagKey)
 	s.Equal(1, len(decision.Reasons))

pkg/decide/decide_errors.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2020, Optimizely, Inc. and contributors                        *
+ * Copyright 2020-2021, Optimizely, Inc. and contributors                   *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -34,10 +34,10 @@ const (
 
 // GetDecideMessage returns message for decide type
 func GetDecideMessage(messageType decideMessage, arguments ...interface{}) string {
-	return fmt.Sprintf(string(messageType), arguments)
+	return fmt.Sprintf(string(messageType), arguments...)
 }
 
 // GetDecideError returns error for decide type
 func GetDecideError(messageType decideMessage, arguments ...interface{}) error {
-	return fmt.Errorf(string(messageType), arguments)
+	return fmt.Errorf(string(messageType), arguments...)
 }