Skip to content

Commit 7227d9e

Browse files
rename default event processor to InMemQueueEventProcessor
1 parent 4b803c3 commit 7227d9e

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

examples/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func main() {
2121

2222
processor.ProcessImpression(impression)
2323

24-
_, ok := processor.(*event.DefaultEventProcessor)
24+
_, ok := processor.(*event.InMemQueueEventProcessor)
2525

2626
if ok {
2727
time.Sleep(1000 * time.Millisecond)

optimizely/event/factory_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func TestCreateImpressionEvent(t *testing.T) {
8484

8585
processor.ProcessImpression(logEvent)
8686

87-
result, ok := processor.(*DefaultEventProcessor)
87+
result, ok := processor.(*InMemQueueEventProcessor)
8888

8989
if ok {
9090
assert.Equal(t, 1, result.EventsCount())
@@ -103,7 +103,7 @@ func TestCreateConversionEvent(t *testing.T) {
103103

104104
processor.ProcessImpression(logEvent)
105105

106-
result, ok := processor.(*DefaultEventProcessor)
106+
result, ok := processor.(*InMemQueueEventProcessor)
107107

108108
if ok {
109109
assert.Equal(t, 1, result.EventsCount())

optimizely/event/processor.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ type Processor interface {
1111
ProcessImpression(event UserEvent)
1212
}
1313

14-
// DefaultEventProcessor is used out of the box by the SDK
15-
type DefaultEventProcessor struct {
14+
// InMemQueueEventProcessor is used out of the box by the SDK
15+
type InMemQueueEventProcessor struct {
1616
MaxQueueSize int // max size of the queue before flush
1717
FlushInterval time.Duration // in milliseconds
1818
BatchSize int
@@ -23,13 +23,13 @@ type DefaultEventProcessor struct {
2323
}
2424

2525
func NewEventProcessor(queueSize int, flushInterval time.Duration ) Processor {
26-
p := &DefaultEventProcessor{MaxQueueSize: queueSize, FlushInterval:flushInterval, Q:NewInMemoryQueue(queueSize), EventDispatcher:&HttpEventDispatcher{}}
26+
p := &InMemQueueEventProcessor{MaxQueueSize: queueSize, FlushInterval:flushInterval, Q:NewInMemoryQueue(queueSize), EventDispatcher:&HttpEventDispatcher{}}
2727
p.StartTicker()
2828
return p
2929
}
3030

3131
// ProcessImpression processes the given impression event
32-
func (p *DefaultEventProcessor) ProcessImpression(event UserEvent) {
32+
func (p *InMemQueueEventProcessor) ProcessImpression(event UserEvent) {
3333
p.Q.Add(event)
3434

3535
if p.Q.Size() >= p.MaxQueueSize {
@@ -39,19 +39,19 @@ func (p *DefaultEventProcessor) ProcessImpression(event UserEvent) {
3939
}
4040
}
4141

42-
func (p *DefaultEventProcessor) EventsCount() int {
42+
func (p *InMemQueueEventProcessor) EventsCount() int {
4343
return p.Q.Size()
4444
}
4545

46-
func (p *DefaultEventProcessor) GetEvents(count int) []interface{} {
46+
func (p *InMemQueueEventProcessor) GetEvents(count int) []interface{} {
4747
return p.Q.Get(count)
4848
}
4949

50-
func (p *DefaultEventProcessor) Remove(count int) []interface{} {
50+
func (p *InMemQueueEventProcessor) Remove(count int) []interface{} {
5151
return p.Q.Remove(count)
5252
}
5353

54-
func (p *DefaultEventProcessor) StartTicker() {
54+
func (p *InMemQueueEventProcessor) StartTicker() {
5555
if p.Ticker != nil {
5656
return
5757
}
@@ -64,7 +64,7 @@ func (p *DefaultEventProcessor) StartTicker() {
6464
}
6565

6666
// ProcessImpression processes the given impression event
67-
func (p *DefaultEventProcessor) FlushEvents() {
67+
func (p *InMemQueueEventProcessor) FlushEvents() {
6868
// we flush when queue size is reached.
6969
// however, if there is a ticker cycle already processing, we should wait
7070
p.Mux.Lock()

optimizely/event/processor_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ func TestDefaultEventProcessor_ProcessImpression(t *testing.T) {
1414

1515
processor.ProcessImpression(impression)
1616

17-
result, ok := processor.(*DefaultEventProcessor)
17+
result, ok := processor.(*InMemQueueEventProcessor)
1818

1919
if ok {
2020
assert.Equal(t, 1, result.EventsCount())
@@ -38,7 +38,7 @@ func TestDefaultEventProcessor_ProcessImpressions(t *testing.T) {
3838
processor.ProcessImpression(impression)
3939
processor.ProcessImpression(impression)
4040

41-
result, ok := processor.(*DefaultEventProcessor)
41+
result, ok := processor.(*InMemQueueEventProcessor)
4242

4343
if ok {
4444
assert.Equal(t, 2, result.EventsCount())

0 commit comments

Comments
 (0)