adding project config support

Author: Mat001

pkg/config/datafileprojectconfig/entities/entities.go

@@ -69,6 +69,7 @@ type FeatureFlag struct {
 	Key           string     `json:"key"`
 	ExperimentIDs []string   `json:"experimentIds"`
 	Variables     []Variable `json:"variables"`
+	HoldoutIDs    []string   `json:"holdoutIds"`
 }
 
 // Variable represents a Variable object from the Optimizely datafile

pkg/config/datafileprojectconfig/mappers/feature.go

@@ -62,6 +62,7 @@ func MapFeatures(featureFlags []datafileEntities.FeatureFlag, rolloutMap map[str
 		feature.ExperimentIDs = featureFlag.ExperimentIDs
 		feature.FeatureExperiments = featureExperiments
 		feature.VariableMap = variableMap
+		feature.HoldoutIDs = featureFlag.HoldoutIDs
 		featureMap[featureFlag.Key] = feature
 	}
 	return featureMap

pkg/config/datafileprojectconfig/mappers/feature_test.go

@@ -67,6 +67,7 @@ func TestMapFeatures(t *testing.T) {
 			Rollout:            rollout,
 			FeatureExperiments: []entities.Experiment{experiment31111},
 			VariableMap:        map[string]entities.Variable{variable.Key: variable},
+			HoldoutIDs:         []string(nil),
 		},
 	}
 	expectedExperimentMap := map[string]entities.Experiment{
@@ -77,3 +78,37 @@ func TestMapFeatures(t *testing.T) {
 	assert.Equal(t, expectedFeatureMap, featureMap)
 	assert.Equal(t, expectedExperimentMap, experimentMap)
 }
+
+func TestMapFeaturesWithHoldoutIds(t *testing.T) {
+	const testFeatureFlagString = `{
+		"id": "22222",
+		"key": "test_feature_22222",
+		"rolloutId": "42222",
+		"experimentIds": ["32222"],
+		"variables": [{"defaultValue":"test","id":"2","key":"var","type":"string"}],
+		"holdoutIds": ["holdout_1", "holdout_2"]
+	}`
+
+	var rawFeatureFlag datafileEntities.FeatureFlag
+	var json = jsoniter.ConfigCompatibleWithStandardLibrary
+	json.Unmarshal([]byte(testFeatureFlagString), &rawFeatureFlag)
+
+	rawFeatureFlags := []datafileEntities.FeatureFlag{rawFeatureFlag}
+	rollout := entities.Rollout{ID: "42222"}
+	rolloutMap := map[string]entities.Rollout{
+		"42222": rollout,
+	}
+	experiment32222 := entities.Experiment{ID: "32222"}
+	experimentMap := map[string]entities.Experiment{
+		"32222": experiment32222,
+	}
+	featureMap := MapFeatures(rawFeatureFlags, rolloutMap, experimentMap)
+
+	// Verify that holdoutIds are properly mapped
+	feature := featureMap["test_feature_22222"]
+	expectedHoldoutIds := []string{"holdout_1", "holdout_2"}
+
+	assert.Equal(t, expectedHoldoutIds, feature.HoldoutIDs)
+	assert.Equal(t, "22222", feature.ID)
+	assert.Equal(t, "test_feature_22222", feature.Key)
+}

pkg/entities/feature.go

@@ -25,6 +25,7 @@ type Feature struct {
 	ExperimentIDs      []string
 	Rollout            Rollout
 	VariableMap        map[string]Variable
+	HoldoutIDs         []string
 }
 
 // Rollout represents a feature rollout