feat: set specific error from default project config manager when CDN returns 403 response (#232)

* feat: set specific error from default project config manager when CDN returns 403 response

Author: pawels-optimizely

examples/main.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/optimizely/go-sdk"
 	"github.com/optimizely/go-sdk/pkg/client"
+	"github.com/optimizely/go-sdk/pkg/config"
 	"github.com/optimizely/go-sdk/pkg/event"
 	"github.com/optimizely/go-sdk/pkg/logging"
 )
@@ -17,17 +18,27 @@ func main() {
 	sdkKey := "4SLpaJA1r1pgE6T2CoMs9q"
 	logging.SetLogLevel(logging.LogLevelDebug)
 
-	/************* Simple usage ********************/
-
 	user := optimizely.UserContext(
 		"mike ng",
 		map[string]interface{}{
 			"country":      "Unknown",
 			"likes_donuts": true,
 		},
 	)
-	optimizelyClient, err := optimizely.Client(sdkKey)
-	enabled, _ := optimizelyClient.IsFeatureEnabled("mutext_feat", user)
+
+	/************* Bad SDK Key  ********************/
+
+	optimizelyClient, err := optimizely.Client("some_key")
+	enabled, err := optimizelyClient.IsFeatureEnabled("mutext_feat", user)
+	if err == config.Err403Forbidden {
+		fmt.Println("A Valid 403 error received:", config.Err403Forbidden)
+	}
+
+	/************* Simple usage ********************/
+
+	optimizelyClient, err = optimizely.Client(sdkKey)
+	enabled, _ = optimizelyClient.IsFeatureEnabled("mutext_feat", user)
+
 	fmt.Printf("Is feature enabled? %v\n", enabled)
 
 	/************* StaticClient ********************/

pkg/config/polling_manager.go

@@ -45,6 +45,9 @@ const LastModified = "Last-Modified"
 // DatafileURLTemplate is used to construct the endpoint for retrieving the datafile from the CDN
 const DatafileURLTemplate = "https://cdn.optimizely.com/datafiles/%s.json"
 
+// Err403Forbidden is 403Forbidden specific error
+var Err403Forbidden = errors.New("unable to fetch fresh datafile (consider rechecking SDK key), status code: 403 Forbidden")
+
 var cmLogger = logging.GetLogger("PollingConfigManager")
 
 // PollingProjectConfigManager maintains a dynamic copy of the project config by continuously polling for the datafile
@@ -119,6 +122,12 @@ func (cm *PollingProjectConfigManager) SyncConfig() {
 		msg := "unable to fetch fresh datafile"
 		cmLogger.Warning(msg)
 		cm.configLock.Lock()
+
+		if code == http.StatusForbidden {
+			closeMutex(Err403Forbidden)
+			return
+		}
+
 		closeMutex(errors.New(fmt.Sprintf("%s, reason (http status code): %s", msg, e.Error())))
 		return
 	}

pkg/config/polling_manager_test.go

@@ -585,6 +585,9 @@ func TestPollingInterval(t *testing.T) {
 
 	assert.Equal(t, configManager.pollingInterval, 5*time.Second)
 	assert.Equal(t, asyncConfigManager.pollingInterval, 5*time.Second)
+
+	assert.Equal(t, configManager.err, Err403Forbidden)
+	assert.Nil(t, asyncConfigManager.err)
 }
 
 func TestInitialDatafile(t *testing.T) {