[FSSDK-11733] Upgrade linteringo-sdk (#434)

* add conditional to check if cmab experiment

* [FSSDK-11733] Update linter to v1.64.2 and fix deprecations

- Update golangci-lint from v1.54.2 to v1.64.2
- Replace deprecated golint with revive
- Replace deprecated exportloopref with copyloopvar
- Update CI lint job to use Go 1.24
- Fix G115 integer overflow in notification/manager.go
- Suppress style-only rules to avoid breaking API changes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: Mat001

.github/workflows/go.yml

@@ -19,7 +19,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: '1.21.0'
+        go-version: '1.24.0'
     - run: make install lint
 
   unit_test_latest:

.golangci.yml

@@ -1,88 +1,98 @@
 linters-settings:
- govet:
-   enable:
-     - shadow
- # golint removed in newer versions, but works in v1.54.2
- golint:
-   min-confidence: 0
- gocyclo:
-   min-complexity: 16
- # maligned removed - replaced by govet fieldalignment
- dupl:
-   threshold: 100
- goconst:
-   min-len: 2
-   min-occurrences: 2
- misspell:
-   locale: US
- lll:
-   line-length: 140
- gocritic:
-   enabled-tags:
-     - performance
-     - style
-     - experimental
-   disabled-checks:
-     - wrapperFunc
-     - hugeParam
-     - rangeValCopy
- gofmt:
-   simplify: false
+  govet:
+    enable:
+      - shadow
+  revive:
+    min-confidence: 0
+    rules:
+      # Disabled: Would require breaking API changes (Ids -> IDs)
+      - name: var-naming
+        disabled: true
+      # Disabled: Parameters often required for interface compliance
+      - name: unused-parameter
+        disabled: true
+      # Disabled: Style preference, not a bug
+      - name: superfluous-else
+        disabled: true
+      # Disabled: Would require breaking API changes (stuttering names)
+      - name: exported
+        disabled: true
+  gocyclo:
+    min-complexity: 16
+  dupl:
+    threshold: 100
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  misspell:
+    locale: US
+  lll:
+    line-length: 140
+  gocritic:
+    enabled-tags:
+      - performance
+      - style
+      - experimental
+    disabled-checks:
+      - wrapperFunc
+      - hugeParam
+      - rangeValCopy
+  gofmt:
+    simplify: false
 
 linters:
- disable-all: true
- enable:
-   # Core linters
-   - govet
-   - typecheck
-   - ineffassign
-   - gofmt
-   
-   # Static analysis
-   - staticcheck
-   - gosimple
-   - unused
-   
-   # Security
-   - gosec
-   
-   # Style and quality
-   - golint  # deprecated but still works in v1.54.2
-   - stylecheck
-   
-   # Code complexity
-   - gocyclo
-   - dupl
-   - gocritic
-   - nakedret
-   
-   # Performance
-   - prealloc
-   - unconvert
-   
-   # Correctness
-   - unparam
-   - misspell
-   
-   # Replacing deprecated linters
-   - exportloopref  # replaces scopelint (works in v1.54.2)
-   # - fieldalignment # replaces maligned (in govet)
- fast: false
- 
- # Enable additional checks
- enable-all: false
+  disable-all: true
+  enable:
+    # Core linters
+    - govet
+    - typecheck
+    - ineffassign
+    - gofmt
+
+    # Static analysis
+    - staticcheck
+    - gosimple
+    - unused
+
+    # Security
+    - gosec
+
+    # Style and quality
+    - revive
+    - stylecheck
+
+    # Code complexity
+    - gocyclo
+    - dupl
+    - gocritic
+    - nakedret
+
+    # Performance
+    - prealloc
+    - unconvert
+
+    # Correctness
+    - unparam
+    - misspell
+
+    # Loop variable capture (Go 1.22+)
+    - copyloopvar
+  fast: false
+
+  # Enable additional checks
+  enable-all: false
 
 run:
- concurrency: 4
+  concurrency: 4
 
 issues:
- exclude-dirs:
-   - vendor
- exclude-rules:
-   - text: "weak cryptographic primitive"
-     linters:
-       - gosec
- exclude-use-default: false
+  exclude-dirs:
+    - vendor
+  exclude-rules:
+    - text: "weak cryptographic primitive"
+      linters:
+        - gosec
+  exclude-use-default: false
 
 service:
- golangci-lint-version: 1.54.x
+  golangci-lint-version: 1.64.x

Makefile

@@ -23,7 +23,7 @@ cover: ## run unit tests with coverage
 	GO111MODULE=$(GO111MODULE) $(GOTEST) -race ./pkg/... -coverprofile=profile.cov
 
 install: ## installs dev and ci dependencies
-	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.54.2
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.64.2
 
 lint: ## runs `golangci-lint` linters defined in `.golangci.yml` file
 	$(GOLINT) run --out-format=tab --tests=false pkg/...

pkg/notification/manager.go

@@ -63,7 +63,11 @@ func (am *AtomicManager) Remove(id int) {
 	am.lock.Lock()
 	defer am.lock.Unlock()
 
-	handlerID := uint32(id)
+	if id < 0 {
+		am.logger.Debug(fmt.Sprintf("Invalid handler id: %d", id))
+		return
+	}
+	handlerID := uint32(id) // #nosec G115 - id is validated non-negative above
 	if _, ok := am.handlers[handlerID]; ok {
 		delete(am.handlers, handlerID)
 		return