Addressing Mike's feedback

aliabbasrizvi · aliabbasrizvi · commit a3ac5b3b764c · 2019-09-11T16:58:01.000-07:00
diff --git a/optimizely/config/polling_manager.go b/optimizely/config/polling_manager.go
@@ -65,12 +65,12 @@ func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) {
 		}
 	}
 
-	// TODO: Compare revision numbers here and set projectConfig only if the revision number has changed
 	projectConfig, err := datafileprojectconfig.NewDatafileProjectConfig(datafile)
 	if err != nil {
 		cmLogger.Error("failed to create project config", err)
 	}
 
+	// TODO: Compare revision numbers here and set projectConfig only if the revision number has changed
 	cm.configLock.Lock()
 	cm.projectConfig = projectConfig
 	cm.err = err

Original file line number	Diff line number	Diff line change
`@@ -65,12 +65,12 @@ func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) {`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
`68`		`- // TODO: Compare revision numbers here and set projectConfig only if the revision number has changed`
`69`	`68`	`projectConfig, err := datafileprojectconfig.NewDatafileProjectConfig(datafile)`
`70`	`69`	`if err != nil {`
`71`	`70`	`cmLogger.Error("failed to create project config", err)`
`72`	`71`	`}`
`73`	`72`
	`73`	`+ // TODO: Compare revision numbers here and set projectConfig only if the revision number has changed`
`74`	`74`	`cm.configLock.Lock()`
`75`	`75`	`cm.projectConfig = projectConfig`
`76`	`76`	`cm.err = err`