Adding test data. Adjusting for loop. WIP

Author: aliabbasrizvi

optimizely/decision/composite_feature_service.go

@@ -46,9 +46,8 @@ func (f CompositeFeatureService) GetDecision(decisionContext FeatureDecisionCont
 
 	// Check if user is bucketed in feature experiment
 	if f.featureExperimentService != nil && len(feature.FeatureExperiments) > 0 {
-		// @TODO this can be improved by getting group ID first and determining experiment ID and then bucketing in experiment ID
-		for idx := 0; idx < len(feature.FeatureExperiments); idx++ {
-			experiment := feature.FeatureExperiments[idx]
+		// @TODO this can be improved by getting group ID first and determining experiment and then bucketing in experiment
+		for _, experiment := range feature.FeatureExperiments {
 			experimentDecisionContext := ExperimentDecisionContext{
 				Experiment:    &experiment,
 				ProjectConfig: decisionContext.ProjectConfig,

optimizely/decision/composite_feature_service_test.go

@@ -0,0 +1,38 @@
+/****************************************************************************
+ * Copyright 2019, Optimizely, Inc. and contributors                        *
+ *                                                                          *
+ * Licensed under the Apache License, Version 2.0 (the "License");          *
+ * you may not use this file except in compliance with the License.         *
+ * You may obtain a copy of the License at                                  *
+ *                                                                          *
+ *    http://www.apache.org/licenses/LICENSE-2.0                            *
+ *                                                                          *
+ * Unless required by applicable law or agreed to in writing, software      *
+ * distributed under the License is distributed on an "AS IS" BASIS,        *
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
+ * See the License for the specific language governing permissions and      *
+ * limitations under the License.                                           *
+ ***************************************************************************/
+
+package decision
+
+import (
+	"github.com/optimizely/go-sdk/optimizely/entities"
+	"testing"
+)
+
+func TestCompositeFeatureServiceGetDecisionFeatureExperiment(t *testing.T) {
+	mockProjectConfig := new(mockProjectConfig)
+	testDecisionContext := FeatureDecisionContext{
+		Feature:       &testFeat3335,
+		ProjectConfig: mockProjectConfig,
+	}
+
+	testUserContext := entities.UserContext{
+		ID: "test_user_1",
+	}
+}
+
+func TestCompositeFeatureServiceGetDecisionRollout(t *testing.T) {
+
+}

optimizely/decision/helpers_test.go

@@ -134,3 +134,70 @@ var testFeatRollout3334 = entities.Feature{
 		Experiments: []entities.Experiment{testExp1112},
 	},
 }
+
+// Feature with test and rollout
+const testFeat3335Key = "test_feature_3335_key"
+// Will use this experiment for feature test
+const testExp1113Key = "test_experiment_1113"
+var testExp1113Var2223 = entities.Variation{ID: "2223", Key: "2223", FeatureEnabled: true}
+var testExp1113Var2224 = entities.Variation{ID: "2224", Key: "2224", FeatureEnabled: false}
+var testExp1113 = entities.Experiment{
+	ID:  "1113",
+	Key: testExp1113Key,
+	GroupID: "6666",
+	Variations: map[string]entities.Variation{
+		"2223": testExp1113Var2223,
+		"2224": testExp1113Var2224,
+	},
+	TrafficAllocation: []entities.Range{
+		entities.Range{EntityID: "2223", EndOfRange: 5000},
+		entities.Range{EntityID: "2224", EndOfRange: 10000},
+	},
+}
+const testExp1114Key = "test_experiment_1114"
+var testExp1114Var2225 = entities.Variation{ID: "2225", Key: "2225", FeatureEnabled: true}
+var testExp1114Var2226 = entities.Variation{ID: "2226", Key: "2226", FeatureEnabled: false}
+var testExp1114 = entities.Experiment{
+	ID:  "1114",
+	Key: testExp1114Key,
+	GroupID: "6666",
+	Variations: map[string]entities.Variation{
+		"2225": testExp1114Var2225,
+		"2226": testExp1114Var2226,
+	},
+	TrafficAllocation: []entities.Range{
+		entities.Range{EntityID: "2225", EndOfRange: 5000},
+		entities.Range{EntityID: "2226", EndOfRange: 10000},
+	},
+}
+var testGroup6666 = entities.Group{
+	ID: "6666",
+	Policy: "random",
+	TrafficAllocation: []entities.Range{
+		entities.Range{EntityID: "1113", EndOfRange: 3000},
+		entities.Range{EntityID: "1114", EndOfRange: 6000},
+	},
+}
+
+// Will use this experiment for rollout
+const testExp1115Key = "test_experiment_1115"
+var testExp1115Var2227 = entities.Variation{ID: "2227", Key: "2227", FeatureEnabled: true}
+var testExp1115 = entities.Experiment{
+	ID:  "1115",
+	Key: testExp1115Key,
+	Variations: map[string]entities.Variation{
+		"2227": testExp1115Var2227,
+	},
+	TrafficAllocation: []entities.Range{
+		entities.Range{EntityID: "2227", EndOfRange: 5000},
+	},
+}
+var testFeat3335 = entities.Feature{
+	ID: "3335",
+	Key: testFeat3335Key,
+	FeatureExperiments: []entities.Experiment{testExp1113, testExp1114},
+	Rollout: entities.Rollout{
+    	ID:          "4445",
+	    Experiments: []entities.Experiment{testExp1115},
+	},
+}