Skip to content

Commit bf67802

Browse files
corrected constructor name
1 parent ce65de5 commit bf67802

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

optimizely/client/factory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func (f OptimizelyFactory) StaticClient() (*OptimizelyClient, error) {
7676
// ClientWithOptions returns a client initialized with the given configuration options
7777
func (f OptimizelyFactory) ClientWithOptions(clientOptions Options) (*OptimizelyClient, error) {
7878

79-
executionCtx := utils.NewCancelableExecutionCtxExecutionCtx()
79+
executionCtx := utils.NewCancelableExecutionCtx()
8080
client := &OptimizelyClient{
8181
isValid: false,
8282
executionCtx: executionCtx,

optimizely/config/polling_manager_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestNewPollingProjectConfigManagerWithOptions(t *testing.T) {
4848
Requester: mockRequester,
4949
}
5050

51-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
51+
exeCtx := utils.NewCancelableExecutionCtx()
5252
configManager := NewPollingProjectConfigManagerWithOptions(exeCtx, sdkKey, options)
5353
mockRequester.AssertExpectations(t)
5454

@@ -67,7 +67,7 @@ func TestNewPollingProjectConfigManagerWithNull(t *testing.T) {
6767
options := PollingProjectConfigManagerOptions{
6868
Requester: mockRequester,
6969
}
70-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
70+
exeCtx := utils.NewCancelableExecutionCtx()
7171
configManager := NewPollingProjectConfigManagerWithOptions(exeCtx, sdkKey, options)
7272
mockRequester.AssertExpectations(t)
7373

optimizely/event/factory_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func TestCreateAndSendImpressionEvent(t *testing.T) {
9191

9292
impressionUserEvent := BuildTestImpressionEvent()
9393

94-
processor := NewEventProcessor(utils.NewCancelableExecutionCtxExecutionCtx(), 10, 100, 100)
94+
processor := NewEventProcessor(utils.NewCancelableExecutionCtx(), 10, 100, 100)
9595

9696
processor.ProcessEvent(impressionUserEvent)
9797

@@ -106,7 +106,7 @@ func TestCreateAndSendConversionEvent(t *testing.T) {
106106

107107
conversionUserEvent := BuildTestConversionEvent()
108108

109-
processor := NewEventProcessor(utils.NewCancelableExecutionCtxExecutionCtx(), 10, 100, 100)
109+
processor := NewEventProcessor(utils.NewCancelableExecutionCtx(), 10, 100, 100)
110110

111111
processor.ProcessEvent(conversionUserEvent)
112112

optimizely/event/processor_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ func close(wg *sync.WaitGroup, cancelFn context.CancelFunc) {
1515
wg.Wait()
1616
}
1717
func TestDefaultEventProcessor_ProcessImpression(t *testing.T) {
18-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
18+
exeCtx := utils.NewCancelableExecutionCtx()
1919
processor := NewEventProcessor(exeCtx, 10, 100, 100)
2020

2121
impression := BuildTestImpressionEvent()
@@ -41,7 +41,7 @@ func (f *MockDispatcher) DispatchEvent(event LogEvent) (bool, error) {
4141
}
4242

4343
func TestDefaultEventProcessor_ProcessBatch(t *testing.T) {
44-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
44+
exeCtx := utils.NewCancelableExecutionCtx()
4545
processor := &QueueingEventProcessor{
4646
MaxQueueSize: 100,
4747
FlushInterval: 100,
@@ -78,7 +78,7 @@ func TestDefaultEventProcessor_ProcessBatch(t *testing.T) {
7878
}
7979

8080
func TestBatchEventProcessor_FlushesOnClose(t *testing.T) {
81-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
81+
exeCtx := utils.NewCancelableExecutionCtx()
8282
processor := &QueueingEventProcessor{
8383
MaxQueueSize: 100,
8484
FlushInterval: 30 * time.Second,
@@ -106,7 +106,7 @@ func TestBatchEventProcessor_FlushesOnClose(t *testing.T) {
106106
}
107107

108108
func TestDefaultEventProcessor_ProcessBatchRevisionMismatch(t *testing.T) {
109-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
109+
exeCtx := utils.NewCancelableExecutionCtx()
110110
processor := &QueueingEventProcessor{
111111
MaxQueueSize: 100,
112112
FlushInterval: 100,
@@ -144,7 +144,7 @@ func TestDefaultEventProcessor_ProcessBatchRevisionMismatch(t *testing.T) {
144144
}
145145

146146
func TestDefaultEventProcessor_ProcessBatchProjectMismatch(t *testing.T) {
147-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
147+
exeCtx := utils.NewCancelableExecutionCtx()
148148
processor := &QueueingEventProcessor{
149149
MaxQueueSize: 100,
150150
FlushInterval: 100,
@@ -182,7 +182,7 @@ func TestDefaultEventProcessor_ProcessBatchProjectMismatch(t *testing.T) {
182182
}
183183

184184
func TestChanQueueEventProcessor_ProcessImpression(t *testing.T) {
185-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
185+
exeCtx := utils.NewCancelableExecutionCtx()
186186
processor := &QueueingEventProcessor{
187187
MaxQueueSize: 100,
188188
FlushInterval: 100,
@@ -206,7 +206,7 @@ func TestChanQueueEventProcessor_ProcessImpression(t *testing.T) {
206206
}
207207

208208
func TestChanQueueEventProcessor_ProcessBatch(t *testing.T) {
209-
exeCtx := utils.NewCancelableExecutionCtxExecutionCtx()
209+
exeCtx := utils.NewCancelableExecutionCtx()
210210
processor := &QueueingEventProcessor{MaxQueueSize: 100, FlushInterval: 100, Q: NewChanQueue(100), EventDispatcher: &MockDispatcher{}, wg: exeCtx.GetWaitSync()}
211211
processor.BatchSize = 10
212212
processor.StartTicker(exeCtx.GetContext())

optimizely/utils/execution_context.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ type CancelableExecutionCtx struct {
4040
CancelFunc context.CancelFunc
4141
}
4242

43-
// NewCancelableExecutionCtxExecutionCtx returns constructed object
44-
func NewCancelableExecutionCtxExecutionCtx() *CancelableExecutionCtx {
43+
// NewCancelableExecutionCtx returns constructed object
44+
func NewCancelableExecutionCtx() *CancelableExecutionCtx {
4545
ctx, cancelFn := context.WithCancel(context.Background())
4646
var wg sync.WaitGroup
4747

0 commit comments

Comments
 (0)