Skip to content

Commit de5082b

Browse files
yasirfolio3Michael Ng
authored andcommitted
feat(coveralls): go-lint implementations and fixes. (WIP) (#54)
1 parent 13a0824 commit de5082b

30 files changed

+149
-106
lines changed

.travis.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ before_install:
66
- go get github.com/mattn/goveralls
77
git:
88
depth: 1
9+
10+
before_script:
11+
- go get -u golang.org/x/lint/golint
912
script:
13+
- golint ./...
1014
- $GOPATH/bin/goveralls -service=travis-ci
1115
stages:
1216
- 'Integration tests'

cmd/is_feature_enabled.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
)
2626

2727
var (
28-
userId string
28+
userID string
2929
featurekKey string
3030
)
3131

@@ -46,19 +46,19 @@ var isFeatureEnabledCmd = &cobra.Command{
4646
}
4747

4848
user := entities.UserContext{
49-
ID: userId,
49+
ID: userID,
5050
Attributes: map[string]interface{}{},
5151
}
5252

5353
enabled, _ := client.IsFeatureEnabled(featurekKey, user)
54-
fmt.Printf("Is feature \"%s\" enabled for \"%s\"? %t\n", featurekKey, userId, enabled)
54+
fmt.Printf("Is feature \"%s\" enabled for \"%s\"? %t\n", featurekKey, userID, enabled)
5555
},
5656
}
5757

5858
func init() {
5959
rootCmd.AddCommand(isFeatureEnabledCmd)
60-
isFeatureEnabledCmd.Flags().StringVarP(&userId, "userId", "u", "", "user id")
61-
isFeatureEnabledCmd.MarkFlagRequired("userId")
60+
isFeatureEnabledCmd.Flags().StringVarP(&userID, "userID", "u", "", "user id")
61+
isFeatureEnabledCmd.MarkFlagRequired("userID")
6262
isFeatureEnabledCmd.Flags().StringVarP(&featurekKey, "featureKey", "f", "", "feature key to enable")
6363
isFeatureEnabledCmd.MarkFlagRequired("featureKey")
6464
}

cmd/root.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ var rootCmd = &cobra.Command{
3030
Short: "go-sdk provides cli access to your Optimizely fullstack project",
3131
}
3232

33+
// Execute executes rootCmd, exits if error found
3334
func Execute() {
3435
if err := rootCmd.Execute(); err != nil {
3536
fmt.Println(err)

optimizely/client/factory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func (f OptimizelyFactory) StaticClient() (*OptimizelyClient, error) {
3737

3838
if f.SDKKey != "" {
3939
url := fmt.Sprintf("https://cdn.optimizely.com/datafiles/%s.json", f.SDKKey)
40-
staticConfigManager, err := config.NewStaticProjectConfigManagerFromUrl(url)
40+
staticConfigManager, err := config.NewStaticProjectConfigManagerFromURL(url)
4141

4242
if err != nil {
4343
return nil, err

optimizely/config/datafileProjectConfig/config.go renamed to optimizely/config/datafileprojectconfig/config.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
* limitations under the License. *
1515
***************************************************************************/
1616

17-
package datafileProjectConfig
17+
package datafileprojectconfig
1818

1919
import (
2020
"errors"
2121
"fmt"
2222

23-
"github.com/optimizely/go-sdk/optimizely/config/datafileProjectConfig/mappers"
23+
"github.com/optimizely/go-sdk/optimizely/config/datafileprojectconfig/mappers"
2424
"github.com/optimizely/go-sdk/optimizely/entities"
2525
"github.com/optimizely/go-sdk/optimizely/logging"
2626
)
@@ -44,26 +44,32 @@ type DatafileProjectConfig struct {
4444
rolloutMap map[string]entities.Rollout
4545
}
4646

47+
// GetProjectID returns projectID
4748
func (c DatafileProjectConfig) GetProjectID() string {
4849
return c.projectID
4950
}
5051

52+
// GetRevision returns revision
5153
func (c DatafileProjectConfig) GetRevision() string {
5254
return c.revision
5355
}
5456

57+
// GetAccountID returns accountID
5558
func (c DatafileProjectConfig) GetAccountID() string {
5659
return c.accountID
5760
}
5861

62+
// GetAnonymizeIP returns anonymizeIP
5963
func (c DatafileProjectConfig) GetAnonymizeIP() bool {
6064
return c.anonymizeIP
6165
}
6266

67+
// GetAttributeID returns attributeID
6368
func (c DatafileProjectConfig) GetAttributeID(key string) string {
6469
return c.attributeKeyToIDMap[key]
6570
}
6671

72+
// GetBotFiltering returns GetBotFiltering
6773
func (c DatafileProjectConfig) GetBotFiltering() bool {
6874
return c.botFiltering
6975
}

optimizely/config/datafileProjectConfig/json_parser.go renamed to optimizely/config/datafileprojectconfig/json_parser.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
* limitations under the License. *
1515
***************************************************************************/
1616

17-
package datafileProjectConfig
17+
package datafileprojectconfig
1818

1919
import (
2020
"encoding/json"
2121

22-
"github.com/optimizely/go-sdk/optimizely/config/datafileProjectConfig/entities"
22+
"github.com/optimizely/go-sdk/optimizely/config/datafileprojectconfig/entities"
2323
)
2424

2525
// Parse parses the raw json datafile

optimizely/config/datafileProjectConfig/json_parser_test.go renamed to optimizely/config/datafileprojectconfig/json_parser_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
* limitations under the License. *
1515
***************************************************************************/
1616

17-
package datafileProjectConfig
17+
package datafileprojectconfig
1818

1919
import (
2020
"fmt"
2121
"testing"
2222

23-
"github.com/optimizely/go-sdk/optimizely/config/datafileProjectConfig/entities"
23+
"github.com/optimizely/go-sdk/optimizely/config/datafileprojectconfig/entities"
2424
"github.com/stretchr/testify/assert"
2525
)
2626

optimizely/config/datafileProjectConfig/mappers/audience.go renamed to optimizely/config/datafileprojectconfig/mappers/audience.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package mappers
1818

1919
import (
20-
datafileEntities "github.com/optimizely/go-sdk/optimizely/config/datafileProjectConfig/entities"
20+
datafileEntities "github.com/optimizely/go-sdk/optimizely/config/datafileprojectconfig/entities"
2121
"github.com/optimizely/go-sdk/optimizely/entities"
2222
)
2323

0 commit comments

Comments
 (0)