Skip to content

Commit 016fdcd

Browse files
Remove layerId
1 parent 94cba07 commit 016fdcd

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

core-api/src/main/java/com/optimizely/ab/config/Holdout.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public class Holdout implements ExperimentCore {
4343
private final String id;
4444
private final String key;
4545
private final String status;
46-
private final String layerId;
4746
private final String groupId;
4847

4948
private final List<String> audienceIds;
@@ -54,6 +53,9 @@ public class Holdout implements ExperimentCore {
5453
private final Map<String, Variation> variationKeyToVariationMap;
5554
private final Map<String, Variation> variationIdToVariationMap;
5655
private final Map<String, String> userIdToVariationKeyMap;
56+
// Not necessary for HO
57+
private final String layerId = "";
58+
5759

5860
public enum HoldoutStatus {
5961
RUNNING("Running"),
@@ -73,27 +75,25 @@ public String toString() {
7375
}
7476

7577
@VisibleForTesting
76-
public Holdout(String id, String key, String layerId) {
77-
this(id, key, null, layerId, Collections.emptyList(), null, Collections.emptyList(), Collections.emptyMap(), Collections.emptyList(), "");
78+
public Holdout(String id, String key) {
79+
this(id, key, null, Collections.emptyList(), null, Collections.emptyList(), Collections.emptyMap(), Collections.emptyList(), "");
7880
}
7981

8082
@JsonCreator
8183
public Holdout(@JsonProperty("id") String id,
8284
@JsonProperty("key") String key,
8385
@JsonProperty("status") String status,
84-
@JsonProperty("layerId") String layerId,
8586
@JsonProperty("audienceIds") List<String> audienceIds,
8687
@JsonProperty("audienceConditions") Condition audienceConditions,
8788
@JsonProperty("variations") List<Variation> variations,
8889
@JsonProperty("forcedVariations") Map<String, String> userIdToVariationKeyMap,
8990
@JsonProperty("trafficAllocation") List<TrafficAllocation> trafficAllocation) {
90-
this(id, key, status, layerId, audienceIds, audienceConditions, variations, userIdToVariationKeyMap, trafficAllocation, "");
91+
this(id, key, status, audienceIds, audienceConditions, variations, userIdToVariationKeyMap, trafficAllocation, "");
9192
}
9293

9394
public Holdout(@Nonnull String id,
9495
@Nonnull String key,
9596
@Nullable String status,
96-
@Nullable String layerId,
9797
@Nonnull List<String> audienceIds,
9898
@Nullable Condition audienceConditions,
9999
@Nonnull List<Variation> variations,
@@ -103,7 +103,6 @@ public Holdout(@Nonnull String id,
103103
this.id = id;
104104
this.key = key;
105105
this.status = status == null ? HoldoutStatus.DRAFT.toString() : status;
106-
this.layerId = layerId;
107106
this.audienceIds = Collections.unmodifiableList(audienceIds);
108107
this.audienceConditions = audienceConditions;
109108
this.variations = Collections.unmodifiableList(variations);

0 commit comments

Comments
 (0)