Skip to content

Commit 4235781

Browse files
committed
Fix failures
1 parent 2a7c54e commit 4235781

File tree

7 files changed

+26
-9
lines changed

7 files changed

+26
-9
lines changed

core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,20 +101,20 @@ public class DatafileProjectConfig implements ProjectConfig {
101101
// v2 constructor
102102
public DatafileProjectConfig(String accountId, String projectId, String version, String revision, List<Group> groups,
103103
List<Experiment> experiments, List<Attribute> attributes, List<EventType> eventType,
104-
List<Audience> audiences) {
105-
this(accountId, projectId, version, revision, groups, experiments, attributes, eventType, audiences, false);
104+
List<Audience> audiences, Region region) {
105+
this(accountId, projectId, version, revision, groups, experiments, attributes, eventType, audiences, false, region);
106106
}
107107

108108
// v3 constructor
109109
public DatafileProjectConfig(String accountId, String projectId, String version, String revision, List<Group> groups,
110110
List<Experiment> experiments, List<Attribute> attributes, List<EventType> eventType,
111-
List<Audience> audiences, boolean anonymizeIP) {
111+
List<Audience> audiences, boolean anonymizeIP, Region region) {
112112
this(
113113
accountId,
114114
anonymizeIP,
115115
false,
116116
null,
117-
Region.US,
117+
region,
118118
projectId,
119119
revision,
120120
null,

core-api/src/main/java/com/optimizely/ab/config/parser/DatafileGsonDeserializer.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,18 @@ public ProjectConfig deserialize(JsonElement json, Type typeOfT, JsonDeserializa
112112
sendFlagDecisions = jsonObject.get("sendFlagDecisions").getAsBoolean();
113113
}
114114

115+
ProjectConfig.Region region = ProjectConfig.Region.US;
116+
117+
if (jsonObject.has("region")) {
118+
region = ProjectConfig.Region.valueOf(jsonObject.get("region").getAsString());
119+
}
120+
115121
return new DatafileProjectConfig(
116122
accountId,
117123
anonymizeIP,
118124
sendFlagDecisions,
119125
botFiltering,
126+
region,
120127
projectId,
121128
revision,
122129
sdkKey,

core-api/src/main/java/com/optimizely/ab/config/parser/DatafileJacksonDeserializer.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,18 @@ public DatafileProjectConfig deserialize(JsonParser parser, DeserializationConte
8888
}
8989
}
9090

91+
ProjectConfig.Region region = ProjectConfig.Region.US;
92+
93+
if (node.hasNonNull("region")) {
94+
region = ProjectConfig.Region.valueOf(node.get("region").asText());
95+
}
96+
9197
return new DatafileProjectConfig(
9298
accountId,
9399
anonymizeIP,
94100
sendFlagDecisions,
95101
botFiltering,
102+
region,
96103
projectId,
97104
revision,
98105
sdkKey,

core-api/src/test/java/com/optimizely/ab/config/DatafileProjectConfigTestUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ private static ProjectConfig generateValidProjectConfigV2() {
155155
Collections.<TrafficAllocation>emptyList());
156156
List<Group> groups = asList(randomPolicyGroup, overlappingPolicyGroup);
157157

158-
return new DatafileProjectConfig("789", "1234", "2", "42", groups, experiments, attributes, events, audiences);
158+
return new DatafileProjectConfig("789", "1234", "2", "42", groups, experiments, attributes, events, audiences, ProjectConfig.Region.US);
159159
}
160160

161161
private static final ProjectConfig NO_AUDIENCE_PROJECT_CONFIG_V2 = generateNoAudienceProjectConfigV2();
@@ -208,7 +208,7 @@ private static ProjectConfig generateNoAudienceProjectConfigV2() {
208208
);
209209

210210
return new DatafileProjectConfig("789", "1234", "2", "42", Collections.<Group>emptyList(), experiments, attributes,
211-
events, Collections.<Audience>emptyList());
211+
events, Collections.<Audience>emptyList(), ProjectConfig.Region.US);
212212
}
213213

214214
private static final ProjectConfig VALID_PROJECT_CONFIG_V3 = generateValidProjectConfigV3();
@@ -325,7 +325,7 @@ private static ProjectConfig generateValidProjectConfigV3() {
325325
List<Group> groups = asList(randomPolicyGroup, overlappingPolicyGroup);
326326

327327
return new DatafileProjectConfig("789", "1234", "3", "42", groups, experiments, attributes, events, audiences,
328-
true);
328+
true, ProjectConfig.Region.US);
329329
}
330330

331331
private static final ProjectConfig NO_AUDIENCE_PROJECT_CONFIG_V3 = generateNoAudienceProjectConfigV3();
@@ -378,7 +378,7 @@ private static ProjectConfig generateNoAudienceProjectConfigV3() {
378378
);
379379

380380
return new DatafileProjectConfig("789", "1234", "3", "42", Collections.<Group>emptyList(), experiments, attributes,
381-
events, Collections.<Audience>emptyList(), true);
381+
events, Collections.<Audience>emptyList(), true, ProjectConfig.Region.US);
382382
}
383383

384384
private static final ProjectConfig VALID_PROJECT_CONFIG_V4 = generateValidProjectConfigV4();

core-api/src/test/java/com/optimizely/ab/config/ValidProjectConfigV4.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public class ValidProjectConfigV4 {
4040
private static final String ENVIRONMENT_KEY = "production";
4141
private static final String VERSION = "4";
4242
private static final Boolean SEND_FLAG_DECISIONS = true;
43+
private static final ProjectConfig.Region REGION = ProjectConfig.Region.US;
4344

4445
// attributes
4546
private static final String ATTRIBUTE_HOUSE_ID = "553339214";
@@ -1451,6 +1452,7 @@ public static ProjectConfig generateValidProjectConfigV4() {
14511452
ANONYMIZE_IP,
14521453
SEND_FLAG_DECISIONS,
14531454
BOT_FILTERING,
1455+
REGION,
14541456
PROJECT_ID,
14551457
REVISION,
14561458
SDK_KEY,

core-api/src/test/java/com/optimizely/ab/event/ForwardingEventProcessorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public void setUp() throws Exception {
5050
eventProcessor = new ForwardingEventProcessor(logEvent -> {
5151
assertNotNull(logEvent.getEventBatch());
5252
assertEquals(logEvent.getRequestMethod(), LogEvent.RequestMethod.POST);
53-
assertEquals(logEvent.getEndpointUrl(), EventFactory.EVENT_ENDPOINT);
53+
assertEquals(logEvent.getEndpointUrl(), EventEndpoints.getDefaultEndpoint());
5454
atomicBoolean.set(true);
5555
}, notificationCenter);
5656
}

core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ private ProjectConfig generateOptimizelyConfig() {
212212
true,
213213
true,
214214
true,
215+
ProjectConfig.Region.US,
215216
"3918735994",
216217
"1480511547",
217218
"ValidProjectConfigV4",

0 commit comments

Comments
 (0)