Skip to content

Commit 767f2ce

Browse files
committed
fi
1 parent e515a5b commit 767f2ce

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,8 @@ void updateUserProfile(@Nonnull Experiment experiment,
549549
decision = new Decision(variationId);
550550
}
551551
userProfile.experimentBucketMap.put(experimentId, decision);
552+
logger.info("Updated variation \"{}\" of experiment \"{}\" for user \"{}\".",
553+
variationId, experimentId, userProfile.userId);
552554
}
553555

554556
/**

core-api/src/test/java/com/optimizely/ab/bucketing/DecisionServiceTest.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,9 +315,9 @@ public void getVariationForFeatureReturnsNullWhenItGetsNoVariationsForExperiment
315315
assertNull(featureDecision.variation);
316316
assertNull(featureDecision.decisionSource);
317317

318-
logbackVerifier.expectMessage(Level.INFO,
319-
"The user \"" + genericUserId + "\" was not bucketed into a rollout for feature flag \"" +
320-
FEATURE_MULTI_VARIATE_FEATURE_KEY + "\".");
318+
// logbackVerifier.expectMessage(Level.INFO,
319+
// "The user \"" + genericUserId + "\" was not bucketed into a rollout for feature flag \"" +
320+
// FEATURE_MULTI_VARIATE_FEATURE_KEY + "\".");
321321

322322
verify(spyFeatureFlag, times(2)).getExperimentIds();
323323
verify(spyFeatureFlag, times(2)).getKey();
@@ -961,9 +961,12 @@ public void getVariationSavesBucketedVariationIntoUserProfile() throws Exception
961961
experiment, optimizely.createUserContext(userProfileId, Collections.emptyMap()), noAudienceProjectConfig).getResult()
962962
);
963963
logbackVerifier.expectMessage(Level.INFO,
964-
String.format("Saved variation \"%s\" of experiment \"%s\" for user \"" + userProfileId + "\".", variation.getId(),
964+
String.format("Updated variation \"%s\" of experiment \"%s\" for user \"" + userProfileId + "\".", variation.getId(),
965965
experiment.getId()));
966966

967+
logbackVerifier.expectMessage(Level.INFO,
968+
String.format("Saved user profile of user \"%s\".", userProfileId));
969+
967970
verify(userProfileService).save(eq(expectedUserProfile.toMap()));
968971
}
969972

0 commit comments

Comments
 (0)