Skip to content

Commit fcd2c6b

Browse files
Add holdout public method to datafile project config
1 parent 427c153 commit fcd2c6b

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,19 @@ public List<Experiment> getExperiments() {
445445
}
446446

447447
@Override
448-
public List<Holdout> getHoldouts() { return holdoutConfig.getAllHoldouts(); }
448+
public List<Holdout> getHoldouts() {
449+
return holdoutConfig.getAllHoldouts();
450+
}
451+
452+
@Override
453+
public List<Holdout> getHoldoutForFlag(@Nonnull String id) {
454+
return holdoutConfig.getHoldoutForFlag(id);
455+
}
456+
457+
@Override
458+
public Holdout getHoldout(@Nonnull String id) {
459+
return holdoutConfig.getHoldout(id);
460+
}
449461

450462
@Override
451463
public Set<String> getAllSegments() {

core-api/src/main/java/com/optimizely/ab/config/HoldoutConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,4 @@ public Holdout getHoldout(@Nonnull String id) {
159159
public List<Holdout> getAllHoldouts() {
160160
return Collections.unmodifiableList(allHoldouts);
161161
}
162-
}
162+
}

core-api/src/main/java/com/optimizely/ab/config/ProjectConfig.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,16 @@
1616
*/
1717
package com.optimizely.ab.config;
1818

19-
import com.optimizely.ab.config.audience.Audience;
20-
import com.optimizely.ab.error.ErrorHandler;
19+
import java.util.List;
20+
import java.util.Map;
21+
import java.util.Set;
2122

2223
import javax.annotation.CheckForNull;
2324
import javax.annotation.Nonnull;
2425
import javax.annotation.Nullable;
25-
import java.util.List;
26-
import java.util.Map;
27-
import java.util.Set;
26+
27+
import com.optimizely.ab.config.audience.Audience;
28+
import com.optimizely.ab.error.ErrorHandler;
2829

2930
/**
3031
* ProjectConfig is an interface capturing the experiment, variation and feature definitions.
@@ -72,6 +73,10 @@ Experiment getExperimentForKey(@Nonnull String experimentKey,
7273

7374
List<Holdout > getHoldouts();
7475

76+
List<Holdout> getHoldoutForFlag(@Nonnull String id);
77+
78+
Holdout getHoldout(@Nonnull String id);
79+
7580
Set<String> getAllSegments();
7681

7782
List<Experiment> getExperimentsForEventKey(String eventKey);

0 commit comments

Comments
 (0)